Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there anyway to support multiple reporters? #43

Open
tony612 opened this issue May 31, 2016 · 6 comments
Open

Is there anyway to support multiple reporters? #43

tony612 opened this issue May 31, 2016 · 6 comments
Labels

Comments

@tony612
Copy link

tony612 commented May 31, 2016

If my understanding is right, only one reporter is supported in Elixometer at the moment, right? If so, is there anyway to support multiple ones?

@scohen
Copy link
Collaborator

scohen commented May 31, 2016

Right now, no, elixometer only allows you to subscribe to the reporter defined in Application.get_env(:elixometer, :reporter).

If you want to submit a PR for adding this, it should be rather easy.

@tony612
Copy link
Author

tony612 commented May 31, 2016

@scohen Got it, I'll try to solve this. I think this should be a useful feature 😁

@scohen
Copy link
Collaborator

scohen commented May 31, 2016

@tony612 Yes, I agree.

I think it's as simple as allowing a list to be passed to :reporter and checking for that an iterating over it in https://github.com/pinterest/elixometer/blob/master/lib/elixometer.ex#L349

@tony612
Copy link
Author

tony612 commented May 31, 2016

@scohen There's one problem: How about deprecating :reporter to support :reporters?

@scohen
Copy link
Collaborator

scohen commented May 31, 2016

I don't know how I feel about that; soft deprecation is OK, but should emit a warning. Hard deprecation will break things for people (including us).

What are your thoughts? :reporters can take a single names or a list of names?

@tony612
Copy link
Author

tony612 commented Jun 1, 2016

@scohen Yeah, I'm OK with soft deprecation and we can remove :reporter in a future version. I refer :reporters only accept a list of names, which is more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants