Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent AppVeyor wheels and MacPython automatization #1627

Closed
menshikh-iv opened this issue Oct 12, 2017 · 2 comments
Closed

Inconsistent AppVeyor wheels and MacPython automatization #1627

menshikh-iv opened this issue Oct 12, 2017 · 2 comments
Labels
difficulty hard Hard issue: required deep gensim understanding & high python/cython skills testing Issue related with testing (code, documentation, etc)

Comments

@menshikh-iv
Copy link
Contributor

When we release gensim, we need to build wheels for different platforms (win and mac), for now, we have 2 problems

  1. AppVeyor loads fresh wheel to storage always (after each build, not only for release), for this reason, we'll have incorrect wheels in storage after any PR (that's isn't critical, because of all wheels on PyPI), but that's not good. Also, I need to disable AppVeyor when I release (and stop non-release builds), that's critical.
    Fix - push wheels in storage if and only if when we build tag commit in the master branch.

  2. Need to clone/replace/check twice for MacPython (first - for HEAD commit in dev, second - for tag commit in master). Need to automatize this process (at least the first part).
    Fix - maybe we should run a script through webhook or something else.
@menshikh-iv menshikh-iv added difficulty medium Medium issue: required good gensim understanding & python skills testing Issue related with testing (code, documentation, etc) labels Oct 12, 2017
@menshikh-iv
Copy link
Contributor Author

What's need to implement:

  • Add macosx builds to current repository, rejection of MacPython
  • Upload wheel in Appveyour only from master + tag
  • Upload wheel in Travis only from master + tag
  • Add correct notification

@menshikh-iv menshikh-iv added difficulty hard Hard issue: required deep gensim understanding & high python/cython skills and removed difficulty medium Medium issue: required good gensim understanding & python skills labels Nov 14, 2017
@menshikh-iv
Copy link
Contributor Author

Fixed in MacPython/gensim-wheels#7
Related issue #1731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty hard Hard issue: required deep gensim understanding & high python/cython skills testing Issue related with testing (code, documentation, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@menshikh-iv