Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when batch_words > MAX_WORDS_IN_BATCH in word2vec #2801

Open
louisabraham opened this issue Apr 21, 2020 · 3 comments
Open

Warning when batch_words > MAX_WORDS_IN_BATCH in word2vec #2801

louisabraham opened this issue Apr 21, 2020 · 3 comments
Labels
documentation Current issue related to documentation feature Issue described a new feature

Comments

@louisabraham
Copy link

The doc says

     batch_words : int, optional
        Target size (in words) for batches of examples passed to worker threads (and
        thus cython routines).(Larger batches will be passed if individual
        texts are longer than 10000 words, but the standard cython code truncates to that maximum.)

I think a larger value should not be accepted.

@piskvorky
Copy link
Owner

piskvorky commented Apr 21, 2020

Good idea. I'd also get rid of the bracket in the docstring at the same time (the ( and ) symbols, not the content). It reads weird and is not really needed, this is important information.

@louisabraham Can you open a PR?

@piskvorky piskvorky added documentation Current issue related to documentation feature Issue described a new feature labels Apr 21, 2020
@dsandeep0138
Copy link
Contributor

@piskvorky I have worked on the changes. Can you please review and let me know if you have any comments?

Keras related test cases seem to be failing and are unrelated to the changes made. Can you please guide on fixing these?

@piskvorky
Copy link
Owner

Thanks! We'll have a look.

I'm not sure about the failing keras tests – CC @mpenkov .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Current issue related to documentation feature Issue described a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants