Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace all occurences of docFreq with dfs #9

Closed
Dieterbe opened this issue Mar 4, 2011 · 5 comments
Closed

replace all occurences of docFreq with dfs #9

Dieterbe opened this issue Mar 4, 2011 · 5 comments

Comments

@Dieterbe
Copy link
Contributor

Dieterbe commented Mar 4, 2011

most of the gensim codebase uses names like dfs and idfs,
but dictionary still has an attribute docFreq, which is exactly the same thing as a dfs dictionary.
I suggest to replace all occurrences of docFreq with dfs

@piskvorky
Copy link
Owner

Ok why not, go ahead.

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Mar 4, 2011

here you go my friend:
#11

@piskvorky
Copy link
Owner

Thanks again Dieter, I applied the changes and pushed them to develop.

Btw I thought that closes the github pull request automatically, but I can still see it. What gives? Do I have to close it manually?

EDIT: I applied the patch with curl | git am. I think I used some different mechanism before, could that be the reason?

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Mar 5, 2011

not sure. it might. I suggest you add me as a remote, fetch my branch, diff it, and then merge it (or rebase on top of it if you don't want a merge commit), then push to github.
but i'm not sure if that auto-closes the pullrequest either.

@piskvorky
Copy link
Owner

Ok, I'll try that on the next pull.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants