We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In class SeekableRawReader: If we seek(), self._body will be replaced with a new object['Body']:
self._body = self._object.get(Range=range_string)['Body']
But old body should been closed. Why not :
self._body.close() self._body = self._object.get(Range=range_string)['Body']
The text was updated successfully, but these errors were encountered:
I think once the function exits, the old body will get garbage-collected and closed then. I don't have anything to back this up.
However, I agree that closing it explicitly is a better idea. May be worth checking for None before the close.
Are you able to make a PR?
Sorry, something went wrong.
seek
5b58023
No branches or pull requests
In class SeekableRawReader:
If we seek(), self._body will be replaced with a new object['Body']:
But old body should been closed. Why not :
The text was updated successfully, but these errors were encountered: