Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing buffer_size as a transport parameter to the http module #700

Closed
mullenkamp opened this issue Jun 10, 2022 · 3 comments · Fixed by #730
Closed

allow passing buffer_size as a transport parameter to the http module #700

mullenkamp opened this issue Jun 10, 2022 · 3 comments · Fixed by #730

Comments

@mullenkamp
Copy link
Contributor

Hello,

I was just looking through your http open module and I noticed that it is not possible to pass a user-defined buffer_size to the open/BufferedInputBase/SeekableBufferedInputBase. It's hard coded to the DEFAULT_BUFFER_SIZE.
Is there a particular reason why this is not an option to pass as a transport parameter?
A higher buffer_size should make less calls to the requests get response, right?
Thanks!
@mpenkov
Copy link
Collaborator

mpenkov commented Jun 11, 2022

I think the reason is probably because nobody has requested this before. Are you interested in making a PR?

@mullenkamp
Copy link
Contributor Author

Sure, I'm happy to make a PR. The modifications don't seem very complicated.

@mullenkamp
Copy link
Contributor Author

mullenkamp commented Oct 7, 2022 •
edited
Loading

I FINALLY made a PR for this simple edit...sorry it took me so long to get to this...
#730

@mpenkov mpenkov mentioned this issue Oct 16, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added buffer_size parameter to http module mullenkamp/smart_open
2 participants
@mpenkov @mullenkamp