From e52a3022173fb3a2b7b5a5dedae1e736dfb82d0b Mon Sep 17 00:00:00 2001
From: Todd Schiller <todd.schiller@gmail.com>
Date: Wed, 10 Apr 2024 15:52:19 -0400
Subject: [PATCH 01/17] #8206: playwright tests for links

---
 .../tests/sidebar/sidebarLinks.spec.ts        | 62 +++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts

diff --git a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
new file mode 100644
index 0000000000..d543ea56f7
--- /dev/null
+++ b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
@@ -0,0 +1,62 @@
+/*
+ * Copyright (C) 2024 PixieBrix, Inc.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import { test, expect } from "../../fixtures/extensionBase";
+import { ActivateModPage } from "../../pageObjects/extensionConsole/modsPage";
+// @ts-expect-error -- https://youtrack.jetbrains.com/issue/AQUA-711/Provide-a-run-configuration-for-Playwright-tests-in-specs-with-fixture-imports-only
+import { test as base } from "@playwright/test";
+import { getSidebarPage } from "../../utils";
+
+test("8206: clicking links doesn't crash browser", async ({
+  page,
+  extensionId,
+}) => {
+  const modId = "@pixies/test/sidebar-links";
+
+  const modActivationPage = new ActivateModPage(page, extensionId, modId);
+  await modActivationPage.goto();
+
+  await modActivationPage.clickActivateAndWaitForModsPageRedirect();
+
+  await page.goto("/");
+
+  // The mod contains a trigger to open the sidebar on h1
+  await page.click("h1");
+
+  const sideBarPage = await getSidebarPage(page, extensionId);
+  await expect(
+    sideBarPage.getByRole("heading", { name: "Sidebar Links" }),
+  ).toBeVisible();
+
+  await sideBarPage.getByRole("link", { name: "Markdown Text Link" }).click();
+
+  // Is a react-bootstrap button link variant
+  await sideBarPage.getByRole("button", { name: "Open a Tab Link" }).click();
+
+  await sideBarPage.getByRole("link", { name: "HTML Renderer Link" }).click();
+
+  await sideBarPage.getByRole("link", { name: "Embedded Form Link" }).click();
+
+  // FIXME: get these selectors working
+  // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
+  // const pixiebrixFrame = page.frameLocator("iframe").first();
+  // const mainFrame = pixiebrixFrame.frameLocator("iframe").first();
+  // await expect(mainFrame.getByText("Alpha")).toBeVisible();
+  //
+  // const srcdocFrame = mainFrame.frameLocator("iframe").first();
+  // await srcdocFrame.getByRole("link", { name: "IFrame Link" }).click();
+});

From 0fd07f4e2872c2eeab1c364f41fc396a63d09381 Mon Sep 17 00:00:00 2001
From: Todd Schiller <todd.schiller@gmail.com>
Date: Wed, 10 Apr 2024 16:00:16 -0400
Subject: [PATCH 02/17] Open the extension console

---
 end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts | 2 ++
 src/sidebar/Header.tsx                              | 1 +
 2 files changed, 3 insertions(+)

diff --git a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
index d543ea56f7..acd3629598 100644
--- a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
@@ -42,6 +42,8 @@ test("8206: clicking links doesn't crash browser", async ({
     sideBarPage.getByRole("heading", { name: "Sidebar Links" }),
   ).toBeVisible();
 
+  await sideBarPage.getByTitle("Open Extension Console").click();
+
   await sideBarPage.getByRole("link", { name: "Markdown Text Link" }).click();
 
   // Is a react-bootstrap button link variant
diff --git a/src/sidebar/Header.tsx b/src/sidebar/Header.tsx
index e069446183..4fe4208cdd 100644
--- a/src/sidebar/Header.tsx
+++ b/src/sidebar/Header.tsx
@@ -103,6 +103,7 @@ const Header: React.FunctionComponent = () => {
         size="sm"
         variant="link"
         className={headerButtonClassName}
+        title="Open Extension Console"
       >
         <FontAwesomeIcon icon={faCog} />
       </Button>

From 5be8e0e3ca9c86705156a970498033b613d6470f Mon Sep 17 00:00:00 2001
From: Todd Schiller <todd.schiller@gmail.com>
Date: Wed, 10 Apr 2024 16:29:43 -0400
Subject: [PATCH 03/17] Fix jest snapshots

---
 end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts | 2 +-
 src/sidebar/__snapshots__/Header.test.tsx.snap      | 2 ++
 src/sidebar/__snapshots__/SidebarBody.test.tsx.snap | 3 +++
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
index acd3629598..137166553f 100644
--- a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
@@ -55,7 +55,7 @@ test("8206: clicking links doesn't crash browser", async ({
 
   // FIXME: get these selectors working
   // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
-  // const pixiebrixFrame = page.frameLocator("iframe").first();
+  // const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();
   // const mainFrame = pixiebrixFrame.frameLocator("iframe").first();
   // await expect(mainFrame.getByText("Alpha")).toBeVisible();
   //
diff --git a/src/sidebar/__snapshots__/Header.test.tsx.snap b/src/sidebar/__snapshots__/Header.test.tsx.snap
index c082015691..a8569a18b7 100644
--- a/src/sidebar/__snapshots__/Header.test.tsx.snap
+++ b/src/sidebar/__snapshots__/Header.test.tsx.snap
@@ -38,6 +38,7 @@ exports[`Header renders 1`] = `
     <a
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
+      title="Open Extension Console"
     >
       <svg
         aria-hidden="true"
@@ -97,6 +98,7 @@ exports[`Header renders sidebar header logo per organization theme 1`] = `
     <a
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
+      title="Open Extension Console"
     >
       <svg
         aria-hidden="true"
diff --git a/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap b/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
index c8e605b7e6..81c94c7179 100644
--- a/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
+++ b/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
@@ -38,6 +38,7 @@ exports[`SidebarBody it renders error when URL is restricted 1`] = `
     <a
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
+      title="Open Extension Console"
     >
       <svg
         aria-hidden="true"
@@ -141,6 +142,7 @@ exports[`SidebarBody it renders with anonymous user 1`] = `
     <a
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
+      title="Open Extension Console"
     >
       <svg
         aria-hidden="true"
@@ -250,6 +252,7 @@ exports[`SidebarBody it renders with authenticated user 1`] = `
     <a
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
+      title="Open Extension Console"
     >
       <svg
         aria-hidden="true"

From 5a680e07b2cbfb8be29ac526a15319bec2d346c3 Mon Sep 17 00:00:00 2001
From: Todd Schiller <todd.schiller@gmail.com>
Date: Thu, 11 Apr 2024 09:32:51 -0400
Subject: [PATCH 04/17] Add commentary on MS Edge behavior and try to fix

---
 .../tests/sidebar/sidebarLinks.spec.ts        | 28 +++++++++++++++----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
index 137166553f..16e097e83e 100644
--- a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
@@ -18,9 +18,16 @@
 import { test, expect } from "../../fixtures/extensionBase";
 import { ActivateModPage } from "../../pageObjects/extensionConsole/modsPage";
 // @ts-expect-error -- https://youtrack.jetbrains.com/issue/AQUA-711/Provide-a-run-configuration-for-Playwright-tests-in-specs-with-fixture-imports-only
-import { test as base } from "@playwright/test";
+import { type Page, test as base } from "@playwright/test";
 import { getSidebarPage } from "../../utils";
 
+async function openSidebar(page: Page, extensionId: string) {
+  // The mod contains a trigger to open the sidebar on h1. If the sidePanel is already open, it's a NOP
+  await page.click("h1");
+
+  return getSidebarPage(page, extensionId);
+}
+
 test("8206: clicking links doesn't crash browser", async ({
   page,
   extensionId,
@@ -34,26 +41,37 @@ test("8206: clicking links doesn't crash browser", async ({
 
   await page.goto("/");
 
-  // The mod contains a trigger to open the sidebar on h1
-  await page.click("h1");
+  let sideBarPage = await openSidebar(page, extensionId);
 
-  const sideBarPage = await getSidebarPage(page, extensionId);
   await expect(
     sideBarPage.getByRole("heading", { name: "Sidebar Links" }),
   ).toBeVisible();
 
   await sideBarPage.getByTitle("Open Extension Console").click();
 
+  // On MS Edge, opening a new tab closes the sidebar, so we have to re-open it on the page after clicking each link
+  // See https://github.com/w3c/webextensions/issues/588. Alternatively, it might work to change the
+  // openAllLinksInPopups behavior to open in a new window instead of a new tab.
+  sideBarPage = await openSidebar(page, extensionId);
+
   await sideBarPage.getByRole("link", { name: "Markdown Text Link" }).click();
 
+  sideBarPage = await openSidebar(page, extensionId);
+
   // Is a react-bootstrap button link variant
   await sideBarPage.getByRole("button", { name: "Open a Tab Link" }).click();
 
+  sideBarPage = await openSidebar(page, extensionId);
+
   await sideBarPage.getByRole("link", { name: "HTML Renderer Link" }).click();
 
+  sideBarPage = await openSidebar(page, extensionId);
+
   await sideBarPage.getByRole("link", { name: "Embedded Form Link" }).click();
 
-  // FIXME: get these selectors working
+  // TODO: get these selectors working. Also, clicking link in IFrame will crash MS Edge until we fix the issue:
+  //   - https://github.com/pixiebrix/pixiebrix-extension/pull/8223
+  //   - https://github.com/pixiebrix/pixiebrix-extension/pull/8224
   // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
   // const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();
   // const mainFrame = pixiebrixFrame.frameLocator("iframe").first();

From 95b9b860b0a5a81b306281d2a6fe2e466e706da7 Mon Sep 17 00:00:00 2001
From: Todd Schiller <todd.schiller@gmail.com>
Date: Thu, 11 Apr 2024 09:57:47 -0400
Subject: [PATCH 05/17] #8206: add more comments on playwright issues

---
 .../tests/sidebar/sidebarLinks.spec.ts        | 21 ++++++++++++-------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
index 16e097e83e..2de76fd42f 100644
--- a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
@@ -25,7 +25,13 @@ async function openSidebar(page: Page, extensionId: string) {
   // The mod contains a trigger to open the sidebar on h1. If the sidePanel is already open, it's a NOP
   await page.click("h1");
 
-  return getSidebarPage(page, extensionId);
+  const sideBarPage = await getSidebarPage(page, extensionId);
+
+  await expect(
+    sideBarPage.getByRole("heading", { name: "Sidebar Links" }),
+  ).toBeVisible();
+
+  return sideBarPage;
 }
 
 test("8206: clicking links doesn't crash browser", async ({
@@ -41,17 +47,16 @@ test("8206: clicking links doesn't crash browser", async ({
 
   await page.goto("/");
 
+  // On MS Edge, opening a new tab closes the sidebar, so we have to re-open it on the page after clicking each link
+  // See https://github.com/w3c/webextensions/issues/588. Alternatively, it might work to change the
+  // openAllLinksInPopups behavior to open in a new window instead of a new tab
   let sideBarPage = await openSidebar(page, extensionId);
 
-  await expect(
-    sideBarPage.getByRole("heading", { name: "Sidebar Links" }),
-  ).toBeVisible();
-
+  // FIXME: on MS Edge, the click steps fail because MS Edge closes the sidebar when the new tab is opened
+  //   Error: locator.click: Target page, context or browser has been closed
+  // Using `void` didn't seem to help
   await sideBarPage.getByTitle("Open Extension Console").click();
 
-  // On MS Edge, opening a new tab closes the sidebar, so we have to re-open it on the page after clicking each link
-  // See https://github.com/w3c/webextensions/issues/588. Alternatively, it might work to change the
-  // openAllLinksInPopups behavior to open in a new window instead of a new tab.
   sideBarPage = await openSidebar(page, extensionId);
 
   await sideBarPage.getByRole("link", { name: "Markdown Text Link" }).click();

From 591279fe68a43eb6a64814250f10c402328443e2 Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Thu, 9 May 2024 17:52:51 -0400
Subject: [PATCH 06/17] Work around msedge bugs

---
 .../tests/sidebar/sidebarLinks.spec.ts        | 173 ++++++++++++++----
 src/sidebar/Header.tsx                        |   1 +
 2 files changed, 135 insertions(+), 39 deletions(-)

diff --git a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
index 2de76fd42f..b32cfe6d8a 100644
--- a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
@@ -17,9 +17,15 @@
 
 import { test, expect } from "../../fixtures/extensionBase";
 import { ActivateModPage } from "../../pageObjects/extensionConsole/modsPage";
-// @ts-expect-error -- https://youtrack.jetbrains.com/issue/AQUA-711/Provide-a-run-configuration-for-Playwright-tests-in-specs-with-fixture-imports-only
-import { type Page, test as base } from "@playwright/test";
+import {
+  type BrowserContext,
+  type Locator,
+  type Page,
+  // @ts-expect-error -- https://youtrack.jetbrains.com/issue/AQUA-711/Provide-a-run-configuration-for-Playwright-tests-in-specs-with-fixture-imports-only
+  test as base,
+} from "@playwright/test";
 import { getSidebarPage } from "../../utils";
+import { getBaseExtensionConsoleUrl } from "../../pageObjects/constants";
 
 async function openSidebar(page: Page, extensionId: string) {
   // The mod contains a trigger to open the sidebar on h1. If the sidePanel is already open, it's a NOP
@@ -34,54 +40,143 @@ async function openSidebar(page: Page, extensionId: string) {
   return sideBarPage;
 }
 
+async function reopenSidebarForMSEdge(page: Page, extensionId: string) {
+  await page.bringToFront();
+  // eslint-disable-next-line playwright/no-wait-for-timeout -- msedge bug
+  await page.waitForTimeout(500);
+  return openSidebar(page, extensionId);
+}
+
+async function clickLinkInSidebarAndWaitForPage(
+  context: BrowserContext,
+  locator: Locator,
+  chromiumChannel: string,
+) {
+  const pagePromise = context.waitForEvent("page");
+  if (chromiumChannel === "msedge") {
+    // On MS Edge, opening a new tab closes the sidebar. The click steps fail because MS Edge closes the sidebar when the new tab is opened
+    //  Error: locator.click: Target page, context or browser has been closed.
+    // Even though it errors, the link is still opened in a new tab.
+    // See https://github.com/w3c/webextensions/issues/588.
+    await expect(async () => locator.click()).not.toPass({
+      timeout: 3000,
+    });
+  } else {
+    await locator.click();
+  }
+
+  return pagePromise;
+}
+
 test("8206: clicking links doesn't crash browser", async ({
   page,
+  context,
   extensionId,
+  chromiumChannel,
+  baseURL,
 }) => {
   const modId = "@pixies/test/sidebar-links";
-
   const modActivationPage = new ActivateModPage(page, extensionId, modId);
   await modActivationPage.goto();
-
   await modActivationPage.clickActivateAndWaitForModsPageRedirect();
 
   await page.goto("/");
-
   // On MS Edge, opening a new tab closes the sidebar, so we have to re-open it on the page after clicking each link
-  // See https://github.com/w3c/webextensions/issues/588. Alternatively, it might work to change the
-  // openAllLinksInPopups behavior to open in a new window instead of a new tab
+  // See https://github.com/w3c/webextensions/issues/588.
   let sideBarPage = await openSidebar(page, extensionId);
 
-  // FIXME: on MS Edge, the click steps fail because MS Edge closes the sidebar when the new tab is opened
-  //   Error: locator.click: Target page, context or browser has been closed
-  // Using `void` didn't seem to help
-  await sideBarPage.getByTitle("Open Extension Console").click();
-
-  sideBarPage = await openSidebar(page, extensionId);
-
-  await sideBarPage.getByRole("link", { name: "Markdown Text Link" }).click();
-
-  sideBarPage = await openSidebar(page, extensionId);
-
-  // Is a react-bootstrap button link variant
-  await sideBarPage.getByRole("button", { name: "Open a Tab Link" }).click();
-
-  sideBarPage = await openSidebar(page, extensionId);
-
-  await sideBarPage.getByRole("link", { name: "HTML Renderer Link" }).click();
-
-  sideBarPage = await openSidebar(page, extensionId);
-
-  await sideBarPage.getByRole("link", { name: "Embedded Form Link" }).click();
-
-  // TODO: get these selectors working. Also, clicking link in IFrame will crash MS Edge until we fix the issue:
-  //   - https://github.com/pixiebrix/pixiebrix-extension/pull/8223
-  //   - https://github.com/pixiebrix/pixiebrix-extension/pull/8224
-  // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
-  // const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();
-  // const mainFrame = pixiebrixFrame.frameLocator("iframe").first();
-  // await expect(mainFrame.getByText("Alpha")).toBeVisible();
-  //
-  // const srcdocFrame = mainFrame.frameLocator("iframe").first();
-  // await srcdocFrame.getByRole("link", { name: "IFrame Link" }).click();
+  await test.step("Clicking extension console link", async () => {
+    const extensionConsolePage = await clickLinkInSidebarAndWaitForPage(
+      context,
+      sideBarPage.getByLabel("Open Extension Console"),
+      chromiumChannel,
+    );
+
+    expect(extensionConsolePage.url()).toContain(
+      getBaseExtensionConsoleUrl(extensionId),
+    );
+
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    if (chromiumChannel === "msedge") {
+      // Another msedge bug causes the browser to fail to open the extension console page from the sidebar until you refresh the page.
+      //   "Error: This script should only be loaded in a browser extension."
+      await extensionConsolePage.reload();
+    }
+
+    await expect(
+      extensionConsolePage.getByText("Extension Console"),
+    ).toBeVisible();
+  });
+
+  await test.step("Clicking markdown text link", async () => {
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    if (chromiumChannel === "msedge") {
+      sideBarPage = await reopenSidebarForMSEdge(page, extensionId);
+    }
+
+    const markdownTextLinkPage = await clickLinkInSidebarAndWaitForPage(
+      context,
+      sideBarPage.getByRole("link", { name: "Markdown Text Link" }),
+      chromiumChannel,
+    );
+    expect(markdownTextLinkPage.url()).toBe(`${baseURL}/bootstrap-5/`);
+  });
+
+  await test.step("Clicking react bootstrap link", async () => {
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    if (chromiumChannel === "msedge") {
+      sideBarPage = await reopenSidebarForMSEdge(page, extensionId);
+    }
+
+    const reactBootstrapLinkPage = await clickLinkInSidebarAndWaitForPage(
+      context,
+      sideBarPage.getByRole("button", { name: "Open a Tab Link" }),
+      chromiumChannel,
+    );
+    expect(reactBootstrapLinkPage.url()).toBe(`${baseURL}/bootstrap-5/#gamma`);
+  });
+
+  await test.step("Clicking html renderer link", async () => {
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    if (chromiumChannel === "msedge") {
+      sideBarPage = await reopenSidebarForMSEdge(page, extensionId);
+    }
+
+    const htmlRendererLinkPage = await clickLinkInSidebarAndWaitForPage(
+      context,
+      sideBarPage.getByRole("link", { name: "HTML Renderer Link" }),
+      chromiumChannel,
+    );
+    expect(htmlRendererLinkPage.url()).toBe(`${baseURL}/bootstrap-5/`);
+  });
+
+  await test.step("Clicking embedded form link", async () => {
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    if (chromiumChannel === "msedge") {
+      sideBarPage = await reopenSidebarForMSEdge(page, extensionId);
+    }
+
+    const embeddedFormLinkPage = await clickLinkInSidebarAndWaitForPage(
+      context,
+      sideBarPage.getByRole("link", { name: "Embedded Form Link" }),
+      chromiumChannel,
+    );
+    expect(embeddedFormLinkPage.url()).toBe(`${baseURL}/bootstrap-5/#beta`);
+  });
+
+  // Clicking link in IFrame will crash MS Edge until the issue is fixed
+  // https://github.com/microsoft/MicrosoftEdge-Extensions/issues/145
+  // eslint-disable-next-line playwright/no-conditional-in-test -- see above comment
+  if (chromiumChannel !== "msedge") {
+    await test.step("Clicking link in IFrame", async () => {
+      // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
+      const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();
+      const mainFrame = pixiebrixFrame.frameLocator("iframe").first();
+      // eslint-disable-next-line playwright/no-conditional-expect -- see above
+      await expect(mainFrame.getByText("Alpha")).toBeVisible();
+
+      const srcdocFrame = mainFrame.frameLocator("iframe").first();
+      await srcdocFrame.getByRole("link", { name: "IFrame Link" }).click();
+    });
+  }
 });
diff --git a/src/sidebar/Header.tsx b/src/sidebar/Header.tsx
index 4fe4208cdd..f7512d7911 100644
--- a/src/sidebar/Header.tsx
+++ b/src/sidebar/Header.tsx
@@ -103,6 +103,7 @@ const Header: React.FunctionComponent = () => {
         size="sm"
         variant="link"
         className={headerButtonClassName}
+        aria-label="Open Extension Console"
         title="Open Extension Console"
       >
         <FontAwesomeIcon icon={faCog} />

From 011345d889b9b9ce757732ae0c8ddae1ce67c4d3 Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Fri, 10 May 2024 09:31:59 -0400
Subject: [PATCH 07/17] fix snapshots

---
 src/sidebar/__snapshots__/Header.test.tsx.snap      | 2 ++
 src/sidebar/__snapshots__/SidebarBody.test.tsx.snap | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/src/sidebar/__snapshots__/Header.test.tsx.snap b/src/sidebar/__snapshots__/Header.test.tsx.snap
index a8569a18b7..abea599020 100644
--- a/src/sidebar/__snapshots__/Header.test.tsx.snap
+++ b/src/sidebar/__snapshots__/Header.test.tsx.snap
@@ -36,6 +36,7 @@ exports[`Header renders 1`] = `
       />
     </div>
     <a
+      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"
@@ -96,6 +97,7 @@ exports[`Header renders sidebar header logo per organization theme 1`] = `
       />
     </div>
     <a
+      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"
diff --git a/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap b/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
index 81c94c7179..b6de610a5b 100644
--- a/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
+++ b/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
@@ -36,6 +36,7 @@ exports[`SidebarBody it renders error when URL is restricted 1`] = `
       />
     </div>
     <a
+      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"
@@ -140,6 +141,7 @@ exports[`SidebarBody it renders with anonymous user 1`] = `
       />
     </div>
     <a
+      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"
@@ -250,6 +252,7 @@ exports[`SidebarBody it renders with authenticated user 1`] = `
       />
     </div>
     <a
+      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"

From f9bd5c6943cf53a2b4b6d4bf4a7ee320f1d3ee3f Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Fri, 10 May 2024 11:28:27 -0400
Subject: [PATCH 08/17] wip

---
 .../{sidebar => regressions}/sidebarLinks.spec.ts  | 14 ++++++++------
 src/sidebar/Header.tsx                             |  1 -
 2 files changed, 8 insertions(+), 7 deletions(-)
 rename end-to-end-tests/tests/{sidebar => regressions}/sidebarLinks.spec.ts (93%)

diff --git a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
similarity index 93%
rename from end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
rename to end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
index b32cfe6d8a..5d310c4a92 100644
--- a/end-to-end-tests/tests/sidebar/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
@@ -24,7 +24,7 @@ import {
   // @ts-expect-error -- https://youtrack.jetbrains.com/issue/AQUA-711/Provide-a-run-configuration-for-Playwright-tests-in-specs-with-fixture-imports-only
   test as base,
 } from "@playwright/test";
-import { getSidebarPage } from "../../utils";
+import { ensureVisibility, getSidebarPage } from "../../utils";
 import { getBaseExtensionConsoleUrl } from "../../pageObjects/constants";
 
 async function openSidebar(page: Page, extensionId: string) {
@@ -68,7 +68,7 @@ async function clickLinkInSidebarAndWaitForPage(
   return pagePromise;
 }
 
-test("8206: clicking links doesn't crash browser", async ({
+test("#8206: clicking links doesn't crash browser", async ({
   page,
   context,
   extensionId,
@@ -88,7 +88,7 @@ test("8206: clicking links doesn't crash browser", async ({
   await test.step("Clicking extension console link", async () => {
     const extensionConsolePage = await clickLinkInSidebarAndWaitForPage(
       context,
-      sideBarPage.getByLabel("Open Extension Console"),
+      sideBarPage.getByRole("link", { name: "Open Extension Console" }),
       chromiumChannel,
     );
 
@@ -103,9 +103,11 @@ test("8206: clicking links doesn't crash browser", async ({
       await extensionConsolePage.reload();
     }
 
-    await expect(
-      extensionConsolePage.getByText("Extension Console"),
-    ).toBeVisible();
+    const activeModsHeading = extensionConsolePage.getByRole("heading", {
+      name: "Active Mods",
+    });
+    // `activeModsHeading` may be initially be detached and hidden, so toBeVisible() would immediately fail
+    await ensureVisibility(activeModsHeading, { timeout: 10_000 });
   });
 
   await test.step("Clicking markdown text link", async () => {
diff --git a/src/sidebar/Header.tsx b/src/sidebar/Header.tsx
index f7512d7911..4fe4208cdd 100644
--- a/src/sidebar/Header.tsx
+++ b/src/sidebar/Header.tsx
@@ -103,7 +103,6 @@ const Header: React.FunctionComponent = () => {
         size="sm"
         variant="link"
         className={headerButtonClassName}
-        aria-label="Open Extension Console"
         title="Open Extension Console"
       >
         <FontAwesomeIcon icon={faCog} />

From d74be30ff90ed62e3dc5c1cc8080310069fc6e6b Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Fri, 10 May 2024 11:44:33 -0400
Subject: [PATCH 09/17] fix snapshots

---
 src/sidebar/__snapshots__/Header.test.tsx.snap      | 2 --
 src/sidebar/__snapshots__/SidebarBody.test.tsx.snap | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/src/sidebar/__snapshots__/Header.test.tsx.snap b/src/sidebar/__snapshots__/Header.test.tsx.snap
index abea599020..a8569a18b7 100644
--- a/src/sidebar/__snapshots__/Header.test.tsx.snap
+++ b/src/sidebar/__snapshots__/Header.test.tsx.snap
@@ -36,7 +36,6 @@ exports[`Header renders 1`] = `
       />
     </div>
     <a
-      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"
@@ -97,7 +96,6 @@ exports[`Header renders sidebar header logo per organization theme 1`] = `
       />
     </div>
     <a
-      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"
diff --git a/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap b/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
index b6de610a5b..81c94c7179 100644
--- a/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
+++ b/src/sidebar/__snapshots__/SidebarBody.test.tsx.snap
@@ -36,7 +36,6 @@ exports[`SidebarBody it renders error when URL is restricted 1`] = `
       />
     </div>
     <a
-      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"
@@ -141,7 +140,6 @@ exports[`SidebarBody it renders with anonymous user 1`] = `
       />
     </div>
     <a
-      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"
@@ -252,7 +250,6 @@ exports[`SidebarBody it renders with authenticated user 1`] = `
       />
     </div>
     <a
-      aria-label="Open Extension Console"
       class="button themeColorOverride btn btn-link btn-sm"
       href="chrome-extension://abcxyz/options.html"
       title="Open Extension Console"

From a1b896a609546fa5b859a0cf90e031ccb5697ee4 Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Fri, 10 May 2024 12:32:34 -0400
Subject: [PATCH 10/17] always reopen sidebar

---
 .../tests/regressions/sidebarLinks.spec.ts    | 26 ++++++++++---------
 end-to-end-tests/utils.ts                     | 25 ++++++++++++++++++
 2 files changed, 39 insertions(+), 12 deletions(-)

diff --git a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
index 5d310c4a92..7f6966de7a 100644
--- a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
@@ -24,7 +24,7 @@ import {
   // @ts-expect-error -- https://youtrack.jetbrains.com/issue/AQUA-711/Provide-a-run-configuration-for-Playwright-tests-in-specs-with-fixture-imports-only
   test as base,
 } from "@playwright/test";
-import { ensureVisibility, getSidebarPage } from "../../utils";
+import { ensureVisibility, getBrowserOs, getSidebarPage } from "../../utils";
 import { getBaseExtensionConsoleUrl } from "../../pageObjects/constants";
 
 async function openSidebar(page: Page, extensionId: string) {
@@ -40,9 +40,9 @@ async function openSidebar(page: Page, extensionId: string) {
   return sideBarPage;
 }
 
-async function reopenSidebarForMSEdge(page: Page, extensionId: string) {
+async function reopenSidebar(page: Page, extensionId: string) {
   await page.bringToFront();
-  // eslint-disable-next-line playwright/no-wait-for-timeout -- msedge bug
+  // eslint-disable-next-line playwright/no-wait-for-timeout -- if we try to reopen to quickly, the sidebar does not respond in time since it was just closed
   await page.waitForTimeout(500);
   return openSidebar(page, extensionId);
 }
@@ -75,13 +75,15 @@ test("#8206: clicking links doesn't crash browser", async ({
   chromiumChannel,
   baseURL,
 }) => {
+  const browserOSName = await getBrowserOs(page);
   const modId = "@pixies/test/sidebar-links";
   const modActivationPage = new ActivateModPage(page, extensionId, modId);
   await modActivationPage.goto();
   await modActivationPage.clickActivateAndWaitForModsPageRedirect();
 
   await page.goto("/");
-  // On MS Edge, opening a new tab closes the sidebar, so we have to re-open it on the page after clicking each link
+  // On MS Edge, and in Linux (both chrome and Edge) opening a new tab closes the sidebar,
+  // so we have to re-open it on the page after clicking each link
   // See https://github.com/w3c/webextensions/issues/588.
   let sideBarPage = await openSidebar(page, extensionId);
 
@@ -112,8 +114,8 @@ test("#8206: clicking links doesn't crash browser", async ({
 
   await test.step("Clicking markdown text link", async () => {
     // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
-    if (chromiumChannel === "msedge") {
-      sideBarPage = await reopenSidebarForMSEdge(page, extensionId);
+    if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
+      sideBarPage = await reopenSidebar(page, extensionId);
     }
 
     const markdownTextLinkPage = await clickLinkInSidebarAndWaitForPage(
@@ -126,8 +128,8 @@ test("#8206: clicking links doesn't crash browser", async ({
 
   await test.step("Clicking react bootstrap link", async () => {
     // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
-    if (chromiumChannel === "msedge") {
-      sideBarPage = await reopenSidebarForMSEdge(page, extensionId);
+    if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
+      sideBarPage = await reopenSidebar(page, extensionId);
     }
 
     const reactBootstrapLinkPage = await clickLinkInSidebarAndWaitForPage(
@@ -140,8 +142,8 @@ test("#8206: clicking links doesn't crash browser", async ({
 
   await test.step("Clicking html renderer link", async () => {
     // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
-    if (chromiumChannel === "msedge") {
-      sideBarPage = await reopenSidebarForMSEdge(page, extensionId);
+    if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
+      sideBarPage = await reopenSidebar(page, extensionId);
     }
 
     const htmlRendererLinkPage = await clickLinkInSidebarAndWaitForPage(
@@ -154,8 +156,8 @@ test("#8206: clicking links doesn't crash browser", async ({
 
   await test.step("Clicking embedded form link", async () => {
     // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
-    if (chromiumChannel === "msedge") {
-      sideBarPage = await reopenSidebarForMSEdge(page, extensionId);
+    if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
+      sideBarPage = await reopenSidebar(page, extensionId);
     }
 
     const embeddedFormLinkPage = await clickLinkInSidebarAndWaitForPage(
diff --git a/end-to-end-tests/utils.ts b/end-to-end-tests/utils.ts
index 6c681db216..102f5ab34a 100644
--- a/end-to-end-tests/utils.ts
+++ b/end-to-end-tests/utils.ts
@@ -182,3 +182,28 @@ export async function conditionallyHoverOverMV2Sidebar(page: Page) {
     await sidebarFrame.dispatchEvent("mouseenter");
   }
 }
+
+type OSName = "Windows" | "MacOS" | "Unix" | "Linux" | "Unknown";
+export async function getBrowserOs(page: Page): Promise<OSName> {
+  let OSName: OSName = "Unknown";
+
+  const response = String(await page.evaluate(() => navigator.userAgent));
+
+  if (response.includes("Win")) {
+    OSName = "Windows";
+  }
+
+  if (response.includes("Mac")) {
+    OSName = "MacOS";
+  }
+
+  if (response.includes("X11")) {
+    OSName = "Unix";
+  }
+
+  if (response.includes("Linux")) {
+    OSName = "Linux";
+  }
+
+  return OSName;
+}

From 3e0ae08d1819664f75ff58f99da5d05fcff344a6 Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Mon, 13 May 2024 09:14:47 -0400
Subject: [PATCH 11/17] wip

---
 end-to-end-tests/tests/regressions/sidebarLinks.spec.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
index 7f6966de7a..f509d7f46c 100644
--- a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
@@ -68,7 +68,7 @@ async function clickLinkInSidebarAndWaitForPage(
   return pagePromise;
 }
 
-test("#8206: clicking links doesn't crash browser", async ({
+test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   page,
   context,
   extensionId,

From 1b1e7cfa2efbed0692a0c1e0e9130e71e9e9c91d Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Mon, 13 May 2024 16:55:26 -0400
Subject: [PATCH 12/17] fix e2e flakiness with deleting mods cleanup

---
 .../pageObjects/extensionConsole/modsPage.ts  | 66 +++++++++++--------
 1 file changed, 38 insertions(+), 28 deletions(-)

diff --git a/end-to-end-tests/pageObjects/extensionConsole/modsPage.ts b/end-to-end-tests/pageObjects/extensionConsole/modsPage.ts
index 1930f3462c..dd7ba53ad2 100644
--- a/end-to-end-tests/pageObjects/extensionConsole/modsPage.ts
+++ b/end-to-end-tests/pageObjects/extensionConsole/modsPage.ts
@@ -30,13 +30,28 @@ export class ModsPage {
   }
 
   async goto() {
+    // When loading the mods table a second time, the cached version of the table is shown, but interacting
+    // with the table is inconsistent because once the registry request finishes, the table is re-rendered, and any row dropdowns are closed.
+    // To ensure the table is fully loaded, we wait for the registry request to finish before interacting with the table.
+    const registryPromise = this.page
+      .context()
+      .waitForEvent("requestfinished", (request) => {
+        return request.url().includes("/api/registry/bricks/");
+      });
     await this.page.goto(this.extensionConsoleUrl);
     await expect(this.page.getByText("Extension Console")).toBeVisible();
+    await registryPromise;
+
+    // Check that the page is stable, and that the content has finished loading
     const activeModsHeading = this.page.getByRole("heading", {
       name: "Active Mods",
     });
-    // `activeModsHeading` may be initially be detached and hidden, so toBeVisible() would immediately fail
     await ensureVisibility(activeModsHeading, { timeout: 10_000 });
+    const modTableItems = this.modTableItems();
+    const contentLoadedLocator = this.page
+      .getByText("Welcome to PixieBrix!")
+      .or(modTableItems.nth(0));
+    await expect(contentLoadedLocator).toBeVisible();
   }
 
   async viewAllMods() {
@@ -61,43 +76,38 @@ export class ModsPage {
    * @param modName the name of the standalone mod to delete (must be a standalone mod, not a packaged mod)
    */
   async deleteModByName(modName: string) {
+    await this.page.bringToFront();
     await this.searchModsInput().fill(modName);
+    await expect(this.page.getByText(`results for "${modName}`)).toBeVisible();
     const modToDelete = this.page.locator(".list-group-item", {
       hasText: modName,
     });
     await expect(modToDelete).toBeVisible();
 
-    // There is a race condition in the Page Editor where the action dropdown menu will disappear when
-    // certain network requests resolve, so we need to add handling to retry clicking the dropdown menu if it
-    // disappears.
-    await expect(async () => {
-      await modToDelete.locator(".dropdown").click();
-      const deactivateOption = modToDelete.getByRole("button", {
-        name: "Deactivate",
-      });
-      if (await deactivateOption.isVisible()) {
-        await deactivateOption.click({
-          timeout: 500,
-        });
-      }
+    // Open the dropdown action menu for the specified mod in the table
+    await modToDelete.locator(".dropdown").click();
 
-      await modToDelete.locator(".dropdown").click();
-      const deleteOption = modToDelete.getByRole("button", { name: "Delete" });
-      await expect(deleteOption).toBeVisible({
-        timeout: 500,
-      });
-    }).toPass({
-      timeout: 5000,
+    // Conditionally deactivate the mod
+    const deactivateOption = modToDelete.getByRole("button", {
+      name: "Deactivate",
     });
-
-    await expect(async () => {
-      await modToDelete.locator(".dropdown").click();
-      await this.page.getByRole("button", { name: "Delete" }).click({
-        timeout: 500,
+    if (await deactivateOption.isVisible()) {
+      await deactivateOption.click({
+        timeout: 3000,
       });
-    }).toPass({
-      timeout: 2000,
+      await expect(
+        this.page.getByText(`Deactivated mod: ${modName}`),
+      ).toBeVisible();
+      // Re-open the dropdown action menu to stay in the same state
+      await modToDelete.locator(".dropdown").click();
+    }
+
+    // Click the delete button in the dropdown action menu
+    await modToDelete.getByRole("button", { name: "Delete" }).click({
+      timeout: 3000,
     });
+
+    // Click the delete button in the delete confirmation modal
     await this.page.getByRole("button", { name: "Delete" }).click();
     await expect(
       this.page.getByText(`Deleted mod ${modName} from your account`),

From 021a913f5ca7fe9b0501d6ccaaccc56a8d814ad5 Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Tue, 14 May 2024 09:52:57 -0400
Subject: [PATCH 13/17] lint fix

---
 end-to-end-tests/utils.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/end-to-end-tests/utils.ts b/end-to-end-tests/utils.ts
index 59e0b5fdba..b88cc0e084 100644
--- a/end-to-end-tests/utils.ts
+++ b/end-to-end-tests/utils.ts
@@ -214,7 +214,6 @@ type OSName = "Windows" | "MacOS" | "Unix" | "Linux" | "Unknown";
 // See: https://github.com/microsoft/playwright/pull/30572
 export async function getBrowserOs(page: Page): Promise<OSName> {
   let OSName: OSName = "Unknown";
-  let OSName = "";
 
   const response = String(await page.evaluate(() => navigator.userAgent));
 

From 309c6bc0e3914c0d2e379833f76bf4e31d2388ee Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Wed, 15 May 2024 11:10:56 -0400
Subject: [PATCH 14/17] skip iframe link test in linux

---
 .../tests/regressions/sidebarLinks.spec.ts         | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
index f509d7f46c..51d592c86f 100644
--- a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
@@ -26,6 +26,7 @@ import {
 } from "@playwright/test";
 import { ensureVisibility, getBrowserOs, getSidebarPage } from "../../utils";
 import { getBaseExtensionConsoleUrl } from "../../pageObjects/constants";
+import { MV } from "../../env";
 
 async function openSidebar(page: Page, extensionId: string) {
   // The mod contains a trigger to open the sidebar on h1. If the sidePanel is already open, it's a NOP
@@ -75,6 +76,8 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   chromiumChannel,
   baseURL,
 }) => {
+  test.skip(MV === "2", "MV3 specific test");
+
   const browserOSName = await getBrowserOs(page);
   const modId = "@pixies/test/sidebar-links";
   const modActivationPage = new ActivateModPage(page, extensionId, modId);
@@ -113,7 +116,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   });
 
   await test.step("Clicking markdown text link", async () => {
-    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge and linux bug that causes the sidebar to close on clicking a link
     if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
       sideBarPage = await reopenSidebar(page, extensionId);
     }
@@ -127,7 +130,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   });
 
   await test.step("Clicking react bootstrap link", async () => {
-    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge/linux bug
     if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
       sideBarPage = await reopenSidebar(page, extensionId);
     }
@@ -141,7 +144,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   });
 
   await test.step("Clicking html renderer link", async () => {
-    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge/linux bug
     if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
       sideBarPage = await reopenSidebar(page, extensionId);
     }
@@ -155,7 +158,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   });
 
   await test.step("Clicking embedded form link", async () => {
-    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge bug
+    // eslint-disable-next-line playwright/no-conditional-in-test -- msedge/linux bug
     if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
       sideBarPage = await reopenSidebar(page, extensionId);
     }
@@ -170,8 +173,9 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
 
   // Clicking link in IFrame will crash MS Edge until the issue is fixed
   // https://github.com/microsoft/MicrosoftEdge-Extensions/issues/145
+  // For some reason this also happens in Chrome/Linux in the CI github workflow.
   // eslint-disable-next-line playwright/no-conditional-in-test -- see above comment
-  if (chromiumChannel !== "msedge") {
+  if (chromiumChannel !== "msedge" || browserOSName !== "MacOS") {
     await test.step("Clicking link in IFrame", async () => {
       // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
       const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();

From 40cb8eb254182b16913953a3f5835f652a31fc1b Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Wed, 15 May 2024 11:26:50 -0400
Subject: [PATCH 15/17] fix os check

---
 .../tests/regressions/sidebarLinks.spec.ts             | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
index 51d592c86f..0494a53a27 100644
--- a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
@@ -117,7 +117,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
 
   await test.step("Clicking markdown text link", async () => {
     // eslint-disable-next-line playwright/no-conditional-in-test -- msedge and linux bug that causes the sidebar to close on clicking a link
-    if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
+    if (browserOSName === "Linux" || chromiumChannel === "msedge") {
       sideBarPage = await reopenSidebar(page, extensionId);
     }
 
@@ -131,7 +131,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
 
   await test.step("Clicking react bootstrap link", async () => {
     // eslint-disable-next-line playwright/no-conditional-in-test -- msedge/linux bug
-    if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
+    if (browserOSName === "Linux" || chromiumChannel === "msedge") {
       sideBarPage = await reopenSidebar(page, extensionId);
     }
 
@@ -145,7 +145,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
 
   await test.step("Clicking html renderer link", async () => {
     // eslint-disable-next-line playwright/no-conditional-in-test -- msedge/linux bug
-    if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
+    if (browserOSName === "Linux" || chromiumChannel === "msedge") {
       sideBarPage = await reopenSidebar(page, extensionId);
     }
 
@@ -159,7 +159,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
 
   await test.step("Clicking embedded form link", async () => {
     // eslint-disable-next-line playwright/no-conditional-in-test -- msedge/linux bug
-    if (chromiumChannel === "msedge" || browserOSName !== "MacOS") {
+    if (browserOSName === "Linux" || chromiumChannel === "msedge") {
       sideBarPage = await reopenSidebar(page, extensionId);
     }
 
@@ -175,7 +175,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   // https://github.com/microsoft/MicrosoftEdge-Extensions/issues/145
   // For some reason this also happens in Chrome/Linux in the CI github workflow.
   // eslint-disable-next-line playwright/no-conditional-in-test -- see above comment
-  if (chromiumChannel !== "msedge" || browserOSName !== "MacOS") {
+  if (browserOSName === "Linux" || chromiumChannel !== "msedge") {
     await test.step("Clicking link in IFrame", async () => {
       // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
       const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();

From 3740af75592806402b6625ff735284d7492d5ccf Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Wed, 15 May 2024 12:12:54 -0400
Subject: [PATCH 16/17] fix os check

---
 end-to-end-tests/tests/regressions/sidebarLinks.spec.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
index 0494a53a27..dd885fb404 100644
--- a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
@@ -175,7 +175,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   // https://github.com/microsoft/MicrosoftEdge-Extensions/issues/145
   // For some reason this also happens in Chrome/Linux in the CI github workflow.
   // eslint-disable-next-line playwright/no-conditional-in-test -- see above comment
-  if (browserOSName === "Linux" || chromiumChannel !== "msedge") {
+  if (browserOSName !== "Linux" || chromiumChannel !== "msedge") {
     await test.step("Clicking link in IFrame", async () => {
       // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
       const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();

From 4b6bbede5d9ff2e3145745df44795a42c187c483 Mon Sep 17 00:00:00 2001
From: Eduardo <eduardo@pixiebrix.com>
Date: Wed, 15 May 2024 12:48:45 -0400
Subject: [PATCH 17/17] fix osname check

---
 end-to-end-tests/tests/regressions/sidebarLinks.spec.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
index dd885fb404..3b505393df 100644
--- a/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
+++ b/end-to-end-tests/tests/regressions/sidebarLinks.spec.ts
@@ -175,7 +175,7 @@ test("#8206: clicking links from the sidebar doesn't crash browser", async ({
   // https://github.com/microsoft/MicrosoftEdge-Extensions/issues/145
   // For some reason this also happens in Chrome/Linux in the CI github workflow.
   // eslint-disable-next-line playwright/no-conditional-in-test -- see above comment
-  if (browserOSName !== "Linux" || chromiumChannel !== "msedge") {
+  if (browserOSName !== "Linux" && chromiumChannel !== "msedge") {
     await test.step("Clicking link in IFrame", async () => {
       // PixieBrix uses 2 layers of frames to get around the host page CSP. Test page has 2 layers
       const pixiebrixFrame = sideBarPage.frameLocator("iframe").first();