-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.7 TypeScript types broken #402
Comments
oh !@#$ gonna fix it right now |
I cloned the repo to look into this but I ran into other weird issues. For example the base package has the peer dependencies defined like this:
So the |
Not sure what's causing the problems I'm having but it seems some PIXI packages are version 6.0.4 and some 6.1.0 which causes all sorts of type incompatibilities when trying to build the project with rush. I think the way the dependencies were all changed to peer dependencies in PIXI 6.1.0 will probably need some more changes to work correctly. |
Oh , right, 6.1.0 is out, means i have to change everything because loader typings might be different now . |
Also, i have to use ^, right? |
I think ^ is more common. It allows for minor updates, ie. 6.x.x whereas ~ allows only patch releases, ie. 6.0.x - https://docs.npmjs.com/about-semantic-versioning However according to strict semantic versioning the amount of breaking changes in PIXI v6.1.0 means it should probably have been a v7 release. I'd still say use the caret ^ and let's hope no more breaking changes are coming. Regardless whether you use ^ or ~ all of the |
Can you please check |
|
yes, ILoaderResource->LoaderResource in types |
We have only added the packages that we directly use as dependencies which previously were installed automatically so basically all the stuff that was moved to peer dependencies needs to be added. At the moment those result in a bunch of import errors. Also we have some problems with the extremely hacky And while doing all this I ran into a new issue with 6.1.0: pixijs/pixijs#7674 There might be more but I need to fix some stuff before I know for sure. |
Seems that there is also a bunch of errors from |
sound? same, Loader types :) Gonna poke @bigtimebuddy about that |
I didn't have any problem with |
I'm seeing these weird errors with
I tried also nuking the node_modules and lockfile without any change. It's probably something weird related to our setup. I know this is not the right issue nor the right project even but since this discussion sort of got derailed I'll just comment here. I'll dig in deeper tomorrow to see if I can isolate what's causing this. |
Actually it seems that we had Aaaand also it seems that I have already opened an issue about this earlier (that I completely forgot about because I was just on a two week vacation to reset my brain): pixijs/sound#165 |
Oh its strict stuff, interesting. I leave issue open so people can see it |
Is this related? Perhaps someone can fix it for you. ➤ YN0002: │ pixi-spine@npm:3.0.13 doesn't provide @pixi/app (pd0e0f), requested by @pixi-spine/loader-base package.json: |
Types seem to be broken in v3.0.7 resulting in the following error:
As the error says the
runtime-3.8/index.d.ts
file has an incorrect import from@pixi-spine/base/compile
. Changing this to@pixi-spine/base
manually seems to work as expected.The text was updated successfully, but these errors were encountered: