Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blog Filter by Tags Not Updating Content Area #683

Closed
wants to merge 1 commit into from

Conversation

Swapnilden
Copy link

Related Issue

 #679  

Description

This pull request addresses a bug where the content area does not update correctly when filtering blogs by tags. The changes include fixing element selection, ensuring proper JSON data parsing, and updating the DOM correctly.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / Videos (if applicable)

 N/A

Checklist:

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines outlined in the project's documentation.
  • I have thoroughly tested the changes before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Context:

This bug fix ensures that when a user clicks on a tag filter button, the displayed blogs are correctly filtered and updated. Error handling for the fetch operation has been improved, and a message is displayed if no blogs match the selected tag. The changes have been tested to ensure the content area updates as expected without any errors.

Please review the changes and provide any feedback.

Copy link

Excellent work🚀🚀, @Swapnilden! Thank you for submitting your pull request. Your contribution is valuable, and we appreciate your efforts to improve our project. We will review your changes promptly and provide feedback. Keep up the excellent work! Please remember to check our documentation and guidelines.

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for blogzen-opensource ready!

Name Link
🔨 Latest commit fe8cb00
🔍 Latest deploy log https://app.netlify.com/sites/blogzen-opensource/deploys/6690c00d9a4e65000804fc2b
😎 Deploy Preview https://deploy-preview-683--blogzen-opensource.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations🎉 on creating your first pull request in Blogzen. This is your first pull request.

Copy link

This PR has been automatically closed due to inactivity from the owner for 15 days.

@github-actions github-actions bot added the Stale label Jul 28, 2024
@github-actions github-actions bot closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant