Multiple tests fail with latest upstream ssh package

[eikenb]

They fail on the same thing. Here is an example.

$ go test -integration -v -run TestServerCompareSubsystems
=== RUN TestServerCompareSubsystems
--- FAIL: TestServerCompareSubsystems (0.11s)
server_integration_test.go:348: EOF
server_integration_test.go:407: exit status 255
FAIL
exit status 1
FAIL github.com/pkg/sftp 0.117s

I bisected it down to commit a59c127441a8ae2ad9b0fb300ab36a6558bba697 in the golang.org/x/crypto package. I think I found an upstream bug about it. I'm testing the fix they have for review now.

[eikenb]

Forgot to link to the upstream bug.

golang/go#18861

And the fix under review.

https://go-review.googlesource.com/#/c/36055/1

[eikenb]

I have verified that the fix for the upstream issue fixes these failing tests. I'll leave this ticket open and run tests locally until this is fixed.

[eikenb]

Implemented a hack in for travis so I could start merging without travis failing constantly. Will leave this open thought until I can revert the hack.

[eikenb]

Fixed upstream and workaround removed.