You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there, we (Rust group @sslab-gatech) are scanning crates on crates.io for potential soundness bugs. We noticed that the serde_fressian::wasm::from_ptr function dereferences a raw pointer provided by the user to deserialize:
This method should probably be marked unsafe so that the user upholds the documented invariant of passing in valid pointers with ownership. Otherwise, this allows a user to cause a memory safety bug using entirely safe Rust code such as the following:
fffff142
thread 'main' panicked at 'assertion failed: deserialized == 0x41424344', src/main.rs:32:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Return code 101
The text was updated successfully, but these errors were encountered:
Hi there, we (Rust group @sslab-gatech) are scanning crates on crates.io for potential soundness bugs. We noticed that the
serde_fressian::wasm::from_ptr
function dereferences a raw pointer provided by the user to deserialize:serde-fressian/src/wasm/mod.rs
Lines 76 to 80 in 64e829e
This method should probably be marked
unsafe
so that the user upholds the documented invariant of passing in valid pointers with ownership. Otherwise, this allows a user to cause a memory safety bug using entirely safe Rust code such as the following:This outputs:
The text was updated successfully, but these errors were encountered: