Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split axes #148

Closed
17 tasks done
gabrielkg opened this issue Oct 31, 2019 · 1 comment
Closed
17 tasks done

Split axes #148

gabrielkg opened this issue Oct 31, 2019 · 1 comment
Assignees

Comments

@gabrielkg
Copy link
Member

gabrielkg commented Oct 31, 2019

This issue is a placeholder for bugs related to split axes functionality.

  • (architecture) add dependency on features of added blocks. (done in a0b873c)
  • (architecture) feature request : add dependency on added blocks. (done in a0b873c)
  • getting duplicate g clip-path (in split axis : tracks) for each features result from api.
    description of test result : 1) adding new block to split axis duplicates all features in all blocks (so adding one block to an existing block, all features are loaded twice); this causes the following point 2). (done in 59c7be1):
  • 2) every redraw creates new features in the DOM. (done in 59c7be1, same fix as previous 1)
  • 3) coloring of features does not match colours of labels at top of axis. (done in : 76e09f1, 9a1161b, e05d0f1, f281850)
    • create a unified blockIndex for use by axis title and tracks. (done in : e05d0f1, f281850)
  • Brushable extent of axis is defined by size before resize.
  • Issue when using feature search to add a map: search for a 90k marker eg: IAAV4876, load a genetic map, then IWGSC 90k for that chromosome, then HC genes. No HC genes are loaded, and are not requested on brushing/zooming etc.
  • After deleting an axis that is split, then re-adding the same block, and splitting again, no tracks are drawn even after brushing/zooming. Appears to break any split axis which has the same parent as the axis that was deleted before (eg: loading another block with same parent also does not work).
    Done in 9e9ccdf
  • Feature search no longer places a tick on the axis to identify position of searched features when axis is split.
    Done, tested OK after 9e9ccdf.
    • observed in test, split axis with tracks and feature search ticks; deleted axis and re-added via feature search +, feature search ticks are not displayed, zoom and open split axis, tracks are not displayed, add another block, now feature search ticks and tracks are displayed. repeated again, but noted that re-adding from feature search after axis deletion does not show the data block found in feature search in the axis title, so used view panel to un-view that data block, re-added it from feature search - now it appears in title, and feature search ticks are displayed, and after zoom & open split axis, the tracks are shown, so there is some issue with the viewed status of the data block when axis is deleted and re-added from feature search.
  • When adding a block, axis title is not coloured until features are received (this affects non-split axes situations as well).
  • After splitting axis, update position of axis and paths (often need to drag slightly to force redraw).
  • Resizing window when split axis only resizes left-side axis while right-side axis is unchanged.
    addressed in a549968.
  • When on right side of the screen, split axis often drawn outside window boundary.
    addressed in fab6de1.
  • Paths sometimes drawn across the split axis; for example if split axis is left-most axis, aligned to another axis on the right, paths are drawn to the left-side of the split axis rather than the right side as expected.
    addressed in 5d74194.
    • update layout and paths x position after toggle split axis
@gabrielkg
Copy link
Member Author

gabrielkg commented Oct 31, 2019

Extensions

  • by default, don't filter brush / blockFeaturesInterval
    checkbox to enable this
  • use append for streamed paths
    done in 5d297c6 : added pathsAccumulated.concat(res).
  • alias mongo query (done in 9da058e, with additional work in ..3424955, etc)
  • histogram of feature counts
  • include feature count in datasets+blocks, done but display not always updated.
  • skew for g.blockAdj when dragging axis
  • streaming for blockFeatureIntervals - can leverage the pathsAliases factorisations
  • zoom : see if ignoring that event restores axis drag (maybe time for a better drag handle anyway, maybe shown when hover) (done in 8439670 : Add zoom filter which checks if event is instanceof WheelEvent)
  • streaming aliases : use a simple % (because we don't know how many there will be); use append during RAF for smoother drawing
  • use network tools to investigate chunking of streaming results - is it in http configuration or in frontend debouncing?

Don-Isdale added a commit that referenced this issue Mar 4, 2020
this addresses re-adding after closing a split axis with tracks (#148, partially fixed in 9e9ccdf).
draw-map.js : drawEffect() : add referencesFirst - sort viewed blocks by .referenceBlock.
 14303d7 239649 Mar  4 15:30 frontend/app/components/draw-map.js
This was referenced Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants