Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Germinate Datasource, without requiring url option #375

Closed
Don-Isdale opened this issue May 17, 2024 · 2 comments
Closed

Enable Germinate Datasource, without requiring url option #375

Don-Isdale opened this issue May 17, 2024 · 2 comments
Assignees
@Don-Isdale
Labels
scale:small sys-admin

Comments

@Don-Isdale
Copy link
Collaborator

Don-Isdale commented May 17, 2024 •
edited
Loading

2024May17
Germinate, on plantinformatics.io : no feature flag required : should be on by default.

2024May20
from chat (Pretzel development team weekly), 4:04 PM : G :

  • append (Experimental) to some names, e.g. Germinate, Spark, BrAPI
@Don-Isdale Don-Isdale self-assigned this May 17, 2024
Don-Isdale added a commit that referenced this issue May 21, 2024
@Don-Isdale
closes #375 Enable Germinate Datasource, without requiring url option
d893a7d 
new-datasource-modal.js : typesForSelect() : push {id, name} directly into types, dropping typeNames, to enable appending (Experimental) to some names, e.g. Germinate, Spark, BrAPI.
query-params.js : urlOptions() : add default options.Germinate = true.
@Don-Isdale
Copy link
Collaborator Author

Implementation

Testing

Test :

  • open Pretzel in a new tab
  • click to add a Datasource - the New Datasource modal dialog is displayed
  • click the Server Type pull-down, and it displays 2 options : Pretzel and Germinate. This is shown in the following screen-shot.

Screenshot from 2024-07-08 15-27-30

@gabrielkg
Copy link
Member

Merged and available in feature/upgradeFrontend2. To be tested once #370 is merged into master.

@Don-Isdale Don-Isdale mentioned this issue Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Don-Isdale Don-Isdale

Labels
scale:small sys-admin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Don-Isdale @gabrielkg @kennyAgricultureVic