-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blast returns "The search completed and returned 0 hits" when it fails to run #398
Comments
Deliver errors from blastServer micro-service to web application GUIThe Flask server by default does not deliver error status and error messages on stderr in the reply.
ProgressTo make it easier to propagate the error information back through the layers of the blast server the blastn_cont.bash has been converted to Python blastn_cont.py so it can be called directly as a library function within the blast server, instead of via Flask-Shell2HTTP which then calls out to a bash command process. This is working, and results are shown following.
Commits[feature/workingGroup3_383_GenotypeSearch 051950c] closes #398 : display blast errors in GUI to distinguish errors from empty results |
…empty results feature.js : dnaSequenceSearch() : searchDataOut() : use ErrorStatus() to include status 400 in the error passed back. blastServer.py : allow path of pretzel worktree to be configured - use os.getenv('pretzelDir') in place of /home/ec2-user/pretzel. blastn_cont.bash : discard stdout of which blastn as only the status is required. blastn_request.bash : Handle ~/log being a soft link by appending /. in -d expression. Add variable errorFile : blastn.error. Move definitions of resultDir and resultFile before the first curl so they can be used there also. resultFile : use basename because may be a path. Introduce hostIpDefault to enable FLASK_PORT to be used to override the default 4000. From feature/blastn_contPy 34652180 in .A3 : split up the curl command pipelines to access the exit status of curl. If the curl result has a non-empty .error field, output it prefixed by 'Error:'. Use --no-progress-meter instead of -s to suppress the progress-meter, so that error messages are output. dnaSequenceSearch.bash : in defining blastn in the container case : if resourcesDir is not an absolute path, prefix blastn with serverDir; this was used in development, with servers running from the command line.
CompleteThe listed items for this task are complete and were tested on the test server and then committed. |
Merged into feature/upgradeFrontend2. |
Errors are not being passed back to the front end
Introduction
There are 2 concerns here :
errors in the process of Blast search are causing an empty result.
The error causes were investigated, identified in DNA Sequence Search (Blast) getting errors and returning an empty result to the GUI #401, which records their resolution.
the errors were logged in the blast server log file, but not propagated to the GUI, which is the focus of this issue.
The goal is to ensure that server configuration errors do not present as empty search results, which is misleading. By displaying the error message the Pretzel administrators of the system and the data configuration are enabled to solve the error more readily.
Testing
The errors can be simulated by making one of the Blast database files unreadable, and then performing a DNA Sequence search of that dataset using the Pretzel GUI.
The server log error message will be displayed in the GUI.
The text was updated successfully, but these errors were encountered: