Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload error-report in GUI : typo in JSON upload displays in GUI as [object Object] #428

Closed
Don-Isdale opened this issue Nov 24, 2024 · 2 comments

Comments

@Don-Isdale
Copy link
Collaborator

Syntax errors in JSON upload are not reported properly in the GUI

While uploading a reference JSON (to enable testing of Germinate) with a typographic error in the JSON :
missing "" around blocks, the error was not displayed correctly in the GUI - it was shown as '[object Object]'.

@Don-Isdale
Copy link
Collaborator Author

Changes Implemented

eac5e14 GUI display of error-report from upload

Tested OK on local and dev

Before change :
Screenshot from 2024-12-02 18-01-56

After change, testing both drag-and-drop of JSON file, and adding JSON file via JSON tab and file browser :

Screenshot from 2024-12-02 17-59-05

Screenshot from 2024-12-02 18-00-52

@Don-Isdale Don-Isdale reopened this Dec 3, 2024
@Don-Isdale
Copy link
Collaborator Author

Subsequent issue found on external test server

After installing the above on the external test server, it was found that it was still converting the error message JSON into HTML, which was displayed in the GUI as "[object Object]"

The solution was found and implemented :
4bd2244 prevent JSON error response being converted to HTML, for upload JSON format error

After installing this on the external test server, the correct result was obtained :

Screenshot from 2024-12-03 20-58-54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant