Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to All Datasets after closing and re-opening the Datasets panel-container #438

Closed
Don-Isdale opened this issue Nov 27, 2024 · 2 comments
Assignees

Comments

@Don-Isdale
Copy link
Collaborator

Don-Isdale commented Nov 27, 2024

This sub-issue is part of #431.


Normally the Dataset Explorer shows the 'All Datasets' tab by default, but if the Datasets panel-container is closed and re-opened, it displays the 'Trait' tab, which is not a primary focus for most users - it should again show the 'All Datasets' tab.

@Don-Isdale
Copy link
Collaborator Author

Don-Isdale commented Nov 28, 2024

Changes Implemented

0665dd1 Default to All Datasets after closing and re-opening the Datasets panel-container


Tested OK on local

Screenshot from 2024-11-28 22-52-15
Screenshot from 2024-11-28 22-53-23
Screenshot from 2024-11-28 22-53-44
Screenshot from 2024-11-28 22-54-17

Don-Isdale added a commit that referenced this issue Nov 28, 2024
…el-container

Closes #438.
manage-explorer.js : add initialSelected() : select All Datasets when the BsTab is re-created; as commented, @activeId={{this.activeId}} is passed to <BsTab > so this should not be necessary - recheck after next framework update.
manage-explorer.hbs : Use .initialSelected when dataset type BsTab (datasetTypeTabId) is inserted.
@Don-Isdale
Copy link
Collaborator Author

Test report indicated that the 'All Datasets' contents were not seen

Reported in meeting 2024Dec04.

This was re-tested using the external test server, with both Chrome and Firefox, and not reproduced; it may be a perception caused by the 5second delay, so this change reduces that delay. The issue can be re-evaluated based on this change.

45392b6 reduce delay in display of All Datasets after re-opening Dataset Explorer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant