Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the margin to VCF Genotype Search #439

Closed
Don-Isdale opened this issue Nov 27, 2024 · 1 comment
Closed

Add the margin to VCF Genotype Search #439

Don-Isdale opened this issue Nov 27, 2024 · 1 comment
Assignees
@Don-Isdale

Comments

@Don-Isdale
Copy link
Collaborator

This sub-issue is part of #431.

The panel container 'VCF Genotype Search' does not have a border whereas the other other containers in Search do. I probably left off the border to see how much width the VCF Genotype Search needed, and it doesn't need the full width, so I'll add the border for consistency with the others.
@Don-Isdale Don-Isdale self-assigned this Nov 27, 2024
@Don-Isdale Don-Isdale mentioned this issue Nov 27, 2024
Closed
Don-Isdale added a commit that referenced this issue Nov 29, 2024
@Don-Isdale
Add the margin to VCF Genotype Search
b9e3a67 
Closes #439.
genotype-search.hbs : wrap with <div  class=panel-section> (the Ember classic Components use classNames: [panel-section], which is also available via manage-base).
@Don-Isdale
Copy link
Collaborator Author

Changes Implemented

b9e3a67 Add the margin to VCF Genotype Search

Tested OK on local and dev

Before change :
Screenshot from 2024-11-29 16-05-26

After change :
Screenshot from 2024-11-29 16-04-57

This was referenced Dec 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Don-Isdale Don-Isdale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Don-Isdale