Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce initial right panel width #453

Closed
Don-Isdale opened this issue Dec 5, 2024 · 1 comment
Closed

Reduce initial right panel width #453

Don-Isdale opened this issue Dec 5, 2024 · 1 comment
Assignees
@Don-Isdale

Comments

@Don-Isdale
Copy link
Collaborator

This sub-issue is part of #443.

The Initial width of the right panel has increased in recent releases, which creates more space for the results of the VCF Genotype Search, but less for the axes; in the simple case users will be viewing just 1 axis, but it is felt that the initial right panel width should be reduced.

  • reduce initial right panel width
@Don-Isdale Don-Isdale self-assigned this Dec 5, 2024
@Don-Isdale
Copy link
Collaborator Author

Don-Isdale commented Dec 5, 2024 •
edited
Loading

Changes Implemented

438e9b4 Reduce initial right panel width : don't navigate to GenotypeTable when genotype-search is inserted

Tested on local

Test URL : http://localhost:4200/mapview?options=dataSources%3A0
Screenshot from 2024-12-05 20-14-10

Don-Isdale added a commit that referenced this issue Dec 5, 2024
@Don-Isdale
Reduce initial right panel width : don't navigate to GenotypeTable wh…
438e9b4 
…en genotype-search is inserted

because navigateGenotypeTableP() increases right panel width (rightSplitInstance.setSizes([35, 65])), and this was happening when the app started; now it happens when the user inputs to genotype-search e.g. select dataset.

Closes #453

genotype-search.hbs : drop use of didInsertElement_.
genotype-search.js :
 drop didInsertElement_(), which formerly called this.navigateGenotypeTable().
 lookupMessage() : add dependency manageGenotype.
 vcfGenotypeSearch() : refer to userSettings via this.args instead of manageGenotype.args, which could (unlikely) be undefined or .isDestroying because of resultP.finally(() => later() ).
This was referenced Dec 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Don-Isdale Don-Isdale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Don-Isdale