Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: "libArchive": false in library.json does not work. #3403

Closed
JelleRoets opened this issue Mar 5, 2020 · 4 comments
Closed

Regression: "libArchive": false in library.json does not work. #3403

JelleRoets opened this issue Mar 5, 2020 · 4 comments
Assignees
Labels
bug build system LDF Library Dependency Finder
Milestone

Comments

@JelleRoets
Copy link

What kind of issue is this?

  • [ x ] PlatformIO Core.
    If you’ve found a bug, please provide an information below.

You can erase any parts of this template not applicable to your Issue.


Configuration

Operating system: osx 10.14.6

PlatformIO Version (platformio --version): 4.2.1

Description of problem

According to documentation https://docs.platformio.org/en/latest/librarymanager/config.html#libarchive you should be able to disable archiving compiled source files of a library by setting the build.libArchive flag to false in the library.json file. This worked correctly in pio 4.1.0, however in 4.2.1 the library files are still archived although this flag is set to false.

Steps to Reproduce

  1. Create a library with library.json and add "{"build": {"libArchive": false}}"
  2. Compile your project

Actual Results

The compiled library object files are archived into a .a file

Expected Results

No archive step for this library

Example of library with libArchive flag set to false: https://github.com/JelleRoets/AtmelStart_PlatformIO/blob/master/library.json#L23

@ivankravets ivankravets added this to the 4.2.2 milestone Mar 5, 2020
@ivankravets ivankravets added bug build system LDF Library Dependency Finder labels Mar 5, 2020
@ivankravets ivankravets self-assigned this Mar 5, 2020
@ivankravets
Copy link
Member

Thanks for the report! Sorry for the issue. I extended tests for this case. Please re-test with pio upgrade --dev.

@kzyapkov
Copy link

Broken for me as well, as reported in #3398

pip install -U "platformio<4.3" installs 4.2.1 and works.

@ivankravets ivankravets reopened this Mar 20, 2020
@ivankravets ivankravets modified the milestones: 4.3.0, 4.3.1, 4.4.0 Mar 20, 2020
@ivankravets
Copy link
Member

Sorry, it is a little bit different issue. We have fixed in d32312e

Could you re-test with pio upgrade --dev?

@ivankravets
Copy link
Member

PlatformIO Core 4.3.1 is out! Please upgrade via pio upgrade --dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build system LDF Library Dependency Finder
Projects
None yet
Development

No branches or pull requests

3 participants