Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp is "wrong" in device monitor output using time filter #3712

Closed
hoegge opened this issue Oct 23, 2020 · 3 comments
Closed

Timestamp is "wrong" in device monitor output using time filter #3712

hoegge opened this issue Oct 23, 2020 · 3 comments
Labels
Milestone

Comments

@hoegge
Copy link

hoegge commented Oct 23, 2020

Configuration

Operating system: MacOS X 10.13.6

PlatformIO Version (platformio --version): Core 5.0.1·Home 3.3.0

Description of problem

The timestamp on a new line is shown after a newline / return. That means the time is determined by the previous line and not the current line. So if there is a pause between output, the time of a line will be the time of the previous line and then can be several hours wrong.

Steps to Reproduce

  1. Make a solution produce out put with intervals that are "long enough" to see that the time of a line is the time of the previous line
  2. E.g. print time as output on every line with e.g. 10 seconds between each output
  3. and then it is clear that the time don't match

Actual Results

Expected Results

Timestamp should be the time of first output on a line and not the time of newline /return of the previous line. So don't print the time stamp until there is output on a line

If problems with PlatformIO Build System:

The content of platformio.ini:

; PlatformIO Project Configuration File
;
;   Build options: build flags, source filter
;   Upload options: custom upload port, speed and extra flags
;   Library options: dependencies, extra library storages
;   Advanced options: extra scripting
;
; Please visit documentation for the other options and examples
; https://docs.platformio.org/page/projectconf.html

[env:nanoatmega328]
platform = atmelavr
board = nanoatmega328
framework = arduino
upload_port = /dev/cu.wchusbserialfa140
monitor_port = /dev/cu.wchusbserialfa140
monitor_speed = 74880
monitor_filters = time, colorize
lib_deps = paulstoffregen/OneWire@^2.3.5

Source file to reproduce issue:
n/a

Additional info

@ivankravets
Copy link
Member

@ivankravets ivankravets added this to the 5.0.2 milestone Oct 23, 2020
@hoegge
Copy link
Author

hoegge commented Oct 26, 2020

Yes, I'll try to fix at latest Sunday. Not sure I can build and test, but can try to apply the logic on example monitoring output. Thanks for the file hint

@ivankravets
Copy link
Member

Thanks! Fixed in the latest PlatformIO Core Dev. The final release is planned this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants