Fix CLion 2021.3 support #4085
Merged
Fix CLion 2021.3 support #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New CMake behavior crashes CLion with apostrophe symbols in `add_definitions` clause see https://youtrack.jetbrains.com/issue/CPP-26719
6 tasks
| @@ -75,7 +75,7 @@ set(CMAKE_CXX_STANDARD {{ cxx_stds[-1] }}) | |||
|
|
|||
| if (CMAKE_BUILD_TYPE MATCHES "{{ env_name }}") | |||
| % for define in defines: | |||
| add_definitions(-D'{{!re.sub(r"([\"\(\)#])", r"\\\1", define)}}') | |||
| add_definitions(-D{{!re.sub(r"([\"\(\)#])", r"\\\1", define)}}) | |||
There was a problem hiding this comment.
Can't we use re.escape()
Ex:
add_definitions(-D{{!re.escape(define)}})
|
@pedrosousabarreto Does |
|
I can't test it right now, don't have python3.7 on this machine. A safer approach would be to simply add the space substitution: |
|
@ivankravets Tested and confirmed to work. |
|
@pedrosousabarreto , please make a PR to https://github.com/platformio/platformio-core |
|
@ivankravets Done, see #4105 |
ivankravets
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CMake behavior crashes CLion with apostrophe symbols in
add_definitionsclausesee https://youtrack.jetbrains.com/issue/CPP-26719