Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update util.py #4134

Closed
wants to merge 1 commit into from
Closed

Update util.py #4134

wants to merge 1 commit into from

Conversation

Vittaly
Copy link

@Vittaly Vittaly commented Dec 8, 2021

Fix error with incorrect determination OS version on win 64. Fix for platformio/platform-ststm8#50
Моre info:

platform.machine().lower()
'amd64'
platform.architecture() # return information about Python executable not about OS
('32bit', 'WindowsPE')

@Vittaly
Update util.py
c3dbe0f 
Fix error with incorrect determination OS version on win 64. 
Моre info:
>>> platform.machine().lower()
'amd64'
>>> platform.architecture() # return information about  Python executable not about OS
('32bit', 'WindowsPE')
@CLAassistant
Copy link

CLAassistant commented Dec 8, 2021 •
edited
Loading

CLA assistant check)
All committers have signed the CLA.

@ivankravets ivankravets self-requested a review December 8, 2021 16:14
@ivankravets ivankravets added the bug label Dec 8, 2021
@ivankravets ivankravets added this to the 5.2.4 milestone Dec 8, 2021
@ivankravets
Copy link
Member

Thanks for the PR! It is a historical issue linked to Python 2. Please re-test with pio upgrade --dev.

@Vittaly
Copy link
Author

Vittaly commented Dec 9, 2021 •
edited
Loading

It works for me:
PS > pio upgrade --dev
Please wait while upgrading PlatformIO ...
PlatformIO has been successfully upgraded to 5.2.4b4
Release notes: https://docs.platformio.org/en/latest/history.html
PS > pio platform install ststm8
Platform Manager: ststm8 @ 2.0.0 is already installed
Tool Manager: Installing platformio/toolchain-sdcc @ ~1.40100.0
Unpacking [####################################] 100%
Tool Manager: toolchain-sdcc @ 1.40100.12072 has been installed!
Tool Manager: tool-stm8binutils @ 0.230.0 is already installed
The platform 'ststm8' has been successfully installed!
The rest of the packages will be installed later depending on your build environment.

@ivankravets ivankravets mentioned this pull request Dec 15, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankravets ivankravets Awaiting requested review from ivankravets

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Vittaly @CLAassistant @ivankravets