Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on start game button, doesn't disable the button #27

Open
platput opened this issue May 16, 2023 · 1 comment
Open

Clicking on start game button, doesn't disable the button #27

platput opened this issue May 16, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@platput
Copy link
Owner

platput commented May 16, 2023

When the game creator is waiting for players to join, s/he can forcefully start the game. This button is shown in the GameRoom view. The bug is, how the button doesn't get disabled when user clicks on it.
@platput platput added bug Something isn't working good first issue Good for newcomers labels May 16, 2023
@platput
Copy link
Owner Author

platput commented May 16, 2023

Almost all other actionable buttons have the loading property set based on the user interaction. This button can probably use the same logic, but it needs to be tested to see if there are any side effects before raising a PR. We currently don't have unit tests set up for the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@platput