-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecto.Adapters.ClickHouse.structure_load: not implemented #37
Comments
I will look into this then soonish! |
@ruslandoga I wanted to work on this. How do you set up your dev environement to run command line things such as Do you create a separate app and then just reference your local |
I don't remember exactly what I did during development, I think I tested the callbacks directly: https://github.com/plausible/ecto_ch/blob/master/test/ecto/adapters/clickhouse/structure_test.exs, and once the tests were passing I did a manual test in plausible/analytics. |
Ah perfect, I am doing the same right now |
History shows that I already had "working" code before adding the tests. https://github.com/plausible/ecto_ch/pull/17/files Maybe I used the dev repo: https://github.com/plausible/ecto_ch/blob/master/dev/repo.ex |
Can we support this? I am currently migrating my old clickhouse schema files over and would like to have my old schema in a structure.sql.
Can we not just split on
;
and execute every query step by step with the caveat there is no option for a rollback and that it can fail while executing? I feel like this is reasonable for a load operation since one expects the structure.sql to only be loaded once or during ci jobs on clean fresh databasesThe text was updated successfully, but these errors were encountered: