Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatypes #3

Open
sembaye opened this issue May 24, 2016 · 9 comments
Open

Datatypes #3

sembaye opened this issue May 24, 2016 · 9 comments

Comments

@sembaye
Copy link

sembaye commented May 24, 2016

Hi,
I want to extend the functionality to read/write the remaining basic Datatypes (S5TIME,TIME,CHAR,DATE,TOD). In which places of the src-code do i have to do changes?
Need some hints!!

Thanks

@Lichtjaeger
Copy link

Lichtjaeger commented May 31, 2016

I would like this.
Look from line 1529 to the end of the file. (someone should modularize this package)

Please complete all typs and aliases.
I miss:

  • BOOL (implemented as X)
  • LWORD
  • SINT
  • USINT (implemented as BYTE)
  • UINT
  • UDINT
  • LINT
  • ULINT
  • LREAL
  • S5TIME
  • TIME (implemented as DINT)
  • LTIME
  • DATE
  • TOD
  • LTOD
  • DT
  • LDT
  • DTL
  • WCHAR
  • WSTRING

@gfcittolin
Copy link
Collaborator

@Lichtjaeger I agree with you about modularizing this package. I'm also thinking about making this package behave more like a library, by better controlling logging and proposing some API changes. I'll try to make a pull request on the next few days :)

@plcpeople
Copy link
Owner

I wish I had the time to modularize this as this was my first NPM package and I have learned a lot since. I will post some info on adding datatypes in the coming days (I am travelling this week) but I welcome a major pull request to clean some of this up.

@sembaye sembaye closed this as completed Jun 7, 2016
@Lichtjaeger
Copy link

In my opinion this is an important issue. I don't like that it's closed.

@sembaye
Copy link
Author

sembaye commented Jun 7, 2016

Oki doki

@sagardubal
Copy link

We have been using the Code, everything is working well except for that we are not able to access I/O directly by using "Q0.0" or "i0.0". Kindly advice.

@plcpeople
Copy link
Owner

Can you please post a log of the error that you get? And what model of PLC are you using? Q0.0 and I0.0 should "just work",

@plcpeople
Copy link
Owner

I tested inputs and outputs (both reading and writing, writing only to inputs that were not defined in hardware configuration) and it worked fine on a 315-2 PN/DP. Version 0.1.10 fixed some boolean write issues - that may have been an issue. Please test again.

@klaus0401
Copy link

lreal can just use readDoubleBE while for Lint can ether modify buffer function in Nodejs or just make a new function in nodes7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants