Custom driver support #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks okay please @NoNameProvided review it |
|
@NoNameProvided ping! |
|
Fuck this, I need this changes right now in my new PR, so I'm merging my changes by myself as it's accepted by pleerock 😆 |
|
Lol, I had it open for days as I had no time, now I reviewed and I saw it already merged. Looks good btw so merge is ok. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two things:
Driverinterface and normalBaseDriverclass in favor of one merged abstract classBaseDrivercreateServerfunction to create routing-controller app with 3rd party driver + refactor of basiccreateExpressServeretc. to use unified generic function