Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version is not supported: Got v22.11.0 #1781

Closed
krissik opened this issue Nov 19, 2024 · 5 comments
Closed

Node version is not supported: Got v22.11.0 #1781

krissik opened this issue Nov 19, 2024 · 5 comments

Comments

@krissik
Copy link

krissik commented Nov 19, 2024

Links of affected pages in Plone Documentation, if any.

https://6.docs.plone.org/install/create-project-cookieplone.html

Description

I have installed nvm and node as described here: https://6.docs.plone.org/install/create-project-cookieplone.html#nvm
After running pipx run cookieplone project it says

Node: Node version is not supported: Got v22.11.0    

I expected that node version is ok because I installed as described in the docs.

I have changed node version to 20 and now pipx run cookieplone project works. So either the documentation needs some update or maybe the check for supported node versions?

@stevepiercy
Copy link
Contributor

@krissik thanks for the report. See plone/cookieplone#48, which was fixed in plone/cookieplone#49, and was released in plone/cookieplone@a917cd6. Please try installing the latest version of Cookieplone, and try again, then let us know if the issue persists.

@stevepiercy
Copy link
Contributor

FYI @ericof @sneridagh @davisagli we should probably update docs with minimum versions of Cookieplone, similar to what we do in conf.py.

documentation/docs/conf.py

Lines 439 to 444 in 27c4998

source_replacements = {
"{PLONE_BACKEND_MINOR_VERSION}": "6.0",
"{PLONE_BACKEND_PATCH_VERSION}": "6.0.13",
"{SUPPORTED_PYTHON_VERSIONS_PLONE60}": "3.8, 3.9, 3.10, 3.11, or 3.12",
"{SUPPORTED_PYTHON_VERSIONS_PLONE61}": "3.10, 3.11, or 3.12",
}

For example:

    "{COOKIEPLONE_MINIMUM_VERSION}": "8.1",

Or would that be too much?

@krissik
Copy link
Author

krissik commented Nov 19, 2024

@krissik thanks for the report. See plone/cookieplone#48, which was fixed in plone/cookieplone#49, and was released in plone/cookieplone@a917cd6. Please try installing the latest version of Cookieplone, and try again, then let us know if the issue persists.

It is working with pipx run --spec cookieplone==0.8.1 cookieplone project - Thx!

@stevepiercy
Copy link
Contributor

See related issue plone/cookieplone#53

@stevepiercy
Copy link
Contributor

Closing as fixed. Please reopen if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants