Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated factory handler #47

Closed
mauritsvanrees opened this issue Feb 23, 2022 · 1 comment
Closed

Remove deprecated factory handler #47

mauritsvanrees opened this issue Feb 23, 2022 · 1 comment
Assignees
@mauritsvanrees

Comments

@mauritsvanrees
Copy link
Member

In storage.py we support passing a factory to the scale method. When you use this, we print a warning:

Deprecated usage of factory in plone.scale. Provide an adapter for the factory instead. The kwarg will be dropped with plone.scale 3.0.

Instead it is still there in latest official release 3.1.2. So let's remove it in version 4 then. I will make a PR.
I have already released a 4.0.0a1 today, for Python 3 only. Still works on 5.2 as well, for those who want it.

Current plone.app.tiles still uses the deprecated way, which is probably one reason why it was not removed yet. I can update this package. That should be possible when using plone.namedfile 6.0.0a2.
@mauritsvanrees mauritsvanrees self-assigned this Feb 23, 2022
@mauritsvanrees mauritsvanrees mentioned this issue Feb 23, 2022
Closed
mauritsvanrees referenced this issue Mar 3, 2022
@mauritsvanrees
Removed deprecated factory argument from scale method.
52eaa4a 
This is in the `AnnotationStorage` class and the IImageScaleStorage` interface.
This was already scheduled for removal in `plone.scale` 3.0, but was kept longer.
Fixes `issue 47 <https://github.com/plone/plone.scale/issues/47>`_.
mauritsvanrees referenced this issue Mar 3, 2022
@mauritsvanrees
Removed deprecated factory argument from scale method.
1791f13 
This is in the `AnnotationStorage` class and the IImageScaleStorage` interface.
This was already scheduled for removal in `plone.scale` 3.0, but was kept longer.
Fixes `issue 47 <https://github.com/plone/plone.scale/issues/47>`_.
mauritsvanrees referenced this issue Mar 3, 2022
@mauritsvanrees
Removed deprecated factory argument from scale method.
8ecaa0a 
This is in the `AnnotationStorage` class and the `IImageScaleStorage` interface.
This was already scheduled for removal in `plone.scale` 3.0, but was kept longer.
Fixes `issue 47 <https://github.com/plone/plone.scale/issues/47>`_.
@mauritsvanrees mauritsvanrees mentioned this issue Mar 3, 2022
Merged
mister-roboto referenced this issue in plone/buildout.coredev Mar 4, 2022
@jensens
[fc] Repository: plone.scale
12bc370 
Branch: refs/heads/master
Date: 2022-03-03T12:38:58+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.scale@8ecaa0a

Removed deprecated factory argument from scale method.

This is in the `AnnotationStorage` class and the `IImageScaleStorage` interface.
This was already scheduled for removal in `plone.scale` 3.0, but was kept longer.
Fixes `issue 47 &lt;https://github.com/plone/plone.scale/issues/47&gt;`_.

Files changed:
A news/47.breaking
M plone/scale/storage.py
M plone/scale/tests/test_storage.py
Repository: plone.scale

Branch: refs/heads/master
Date: 2022-03-04T18:02:13+01:00
Author: Jens W. Klein (jensens) <[email protected]>
Commit: plone/plone.scale@b88d8f6

Merge pull request #48 from plone/maurits-remove-deprecated-factory-argument

Removed deprecated factory argument from scale method.

Files changed:
A news/47.breaking
M plone/scale/storage.py
M plone/scale/tests/test_storage.py
@mauritsvanrees
Copy link
Member Author

This is in release 4.0.0a2, and will be included in the next Plone 6 alpha release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mauritsvanrees