Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather_() will likely become defunct in tidyr 1.2.0 #2088

Closed
DavisVaughan opened this issue Dec 17, 2021 · 6 comments · Fixed by #2125
Closed

gather_() will likely become defunct in tidyr 1.2.0 #2088

DavisVaughan opened this issue Dec 17, 2021 · 6 comments · Fixed by #2125

Comments

@DavisVaughan
Copy link

We are planning on moving the lazyeval versions of the main tidyr verbs to the defunct stage in the next version of tidyr. They have been deprecated for awhile now, and the NSE versions can do everything the lazyeval versions were meant to help with. See tidyverse/tidyr#1281 for more information.

Could you please remove your usage of gather_() from plotly?

@cpsievert
Copy link
Collaborator

Was gather_() ever soft-deprecated? Seems extreme to remove it with no prior warning.

@DavisVaughan
Copy link
Author

Oh good point. Most of the lazyeval functions here were soft-deprecated already, but gather_() is one that wasn't. Maybe we should start by soft-deprecating them all in the next release.

@DavisVaughan
Copy link
Author

So, I'd say nothing for you to immediately do, but I do think it would be a good idea to move away from gather_() in the near ish future. Either to gather() or pivot_longer(). I will leave it up to you as to whether or not you want to keep this issue open as a stub for that

@cpsievert
Copy link
Collaborator

Oh definitely, I mainly bring it up out of concern for legacy user code

@msummersgill
Copy link
Contributor

Perhaps another good reason to drop remaining "tidyverse" dependencies in favor of base R functionality and data.table (whose authors respect the value of long term stability -- haven't seen any issues with Group2NA since adding as a dependency 5 years ago) implementations? Would be happy to help on a re-factor if you'd like a PR.

@netique
Copy link

netique commented Mar 16, 2022

gather_ is deprecated in tidyr 1.2.0+ and now throws a warning whenever using plotly. I vote for moving from gather to pivot_longer as gather itself is superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants