Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heavily more visitors since v1.7.0 #149

Closed
MatzeKitt opened this issue May 12, 2020 · 1 comment · Fixed by #151
Closed

Heavily more visitors since v1.7.0 #149

MatzeKitt opened this issue May 12, 2020 · 1 comment · Fixed by #151
Labels
Milestone

Comments

@MatzeKitt
Copy link
Member

I noticed that there are many more visitors on my website since v1.7.0. This seems cool, but I was a little bit pessimistic and thus looked into the server logs.

I noticed that the Icinga uptime check is no more recognised as bot and thus its requests get counted. It seems that this is because the removed check for Mozilla in the user agent.

This is a request:

46.xx.xx.xx - - [11/May/2020:00:00:05 +0200] "GET / HTTP/1.0" 200 53211 "-" "check_http/v2.2 (monitoring-plugins 2.2)"

It would be nice to have such identifiers also in the is_bot() method.

And it would be also nice to be able to filter these identifiers to add/remove them depending on your need.

@stklcode stklcode added this to the 1.7.1 milestone May 12, 2020
@stklcode
Copy link
Contributor

stklcode commented May 12, 2020

Good catch!

Regression form #125
We should either re-add a reasonable whitelist or add “check“ and/or “monitor“ to the blacklist. Sounds familiar from Nagios/Icinga modules...

Btw. PRTG Monitoring add this line:
Mozilla/5.0 (compatible; PRTG Network Monitor (www.paessler.com); Windows)
So +1 for “monitor“. This would have passed the 1.6 whitelist (Windows, Mozilla).

For dynamic user-defined blacklists there is an extension-plugin Statify Blacklist (disclaimer: my plugin). You can at least temporarily block the Monitoring IPs (UA is on my wishlist).
We might discuss whether to merge both functionalities into Statify in future releases.
Until then you can only utilize a custom statify__skip_tracking Hook...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants