Block suddenly appears during Bridge

[nzAily]

Plugin information

I haven't tested without plugins

Problem description

there in the video

pmbug.mp4

Expected behaviour

as normal you can see the video below
i tried it in my own world

2025-01-04.09-39-17.mp4

PocketMine-MP version

5.23.2

PHP version

8.2.17

Server OS

win

Game version (if applicable)

Windows 1.21.51

[iAmFrogger]

Can vouch that this has been happening a LOT more, specially when owning a bridge server

[Josscoder]

I can also vouch for this happens, I have a minigame server and people get very upset about this

[Trollserver]

I figured out that when you bridge like that but you look down it wont happen or when you bridge like that forward without jumping it doesn't happen. - a temporary solution

[dktapps]

If I had to guess, I'd say this was likely caused by ff695a5, since it changed block syncing to always happen on right-click, instead of only on failed actions.

Not sure how else we could achieve this without BC breaks though.
Since the client doesn't tell us what blocks it thinks have changed, we need to guess whether the result action of the interaction was the same as the client expected. It seemed like it was simpler to not guess since the introduction of ff695a5. Bringing back the guesswork logic would be complicated because ff695a5 introduces new ways for an action to succeed without following vanilla.

[Trollserver]

I don't really understand the code that much and what changed so I wanna ask if I can somehow undo the change and if it would break something?

[dktapps]

Yes it would break things. That's why it hasn't been reverted by the team already.