Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extension #112

Closed
dktapps opened this issue May 12, 2023 · 2 comments
Closed

Rename extension #112

dktapps opened this issue May 12, 2023 · 2 comments

Comments

@dktapps
Copy link
Member

dktapps commented May 12, 2023

As of 5.0.0, this extension now has an API that differs quite a bit from pthreads. It's also more performant and is easier to understand.

Since we don't actually have a claim to the name pthreads (this is an unofficial fork), we can't publish the extension to PECL under the pthreads name, and calling it pthreads is possibly misleading. We also can't submit official stubs to jetbrains/phpstorm-stubs, requiring users to install custom stubs for IDE development.

I plan to release 6.0.0 soon, with some class renames and namespacing to distinguish it from pthreads.

Some possible new names (with the help of PM #internals-dev and ChatGPT):

  • pmthreads - the obvious one, but brings up results for Persistent Memory Threads
  • ptx
  • pthreads-ng - the original codename for v5 before release
  • pmmpthreads - most verbose, but doesn't conflict with any known project, and is clear about origins
@SOF3
Copy link
Member

SOF3 commented May 13, 2023

pmmpthreads sounds fine to me. A bit long, but it's not namespaced anyway so users don't need to type it anywhere other than during installation or dependency declaration, and internally we just call it "threading" either way

@dktapps
Copy link
Member Author

dktapps commented May 15, 2023

For consistency with our other projects, I chose a namespace of pmmp\thread. pmmpthread without the s works with this too, I think.

For some reason I instinctively pmmpthreads as "pmm pthreads", while pmmpthread reads as "pmmp thread".

@dktapps dktapps closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants