Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border when embedded since 2022.11.0 #28

Open
2 tasks done
julienlarivee opened this issue Dec 4, 2022 · 6 comments
Open
2 tasks done

Border when embedded since 2022.11.0 #28

julienlarivee opened this issue Dec 4, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@julienlarivee
Copy link

Checklist:

  • I updated to the latest version available
  • I cleared the cache of my browser

Release with the issue:
V0.4

Last working release (if known):
Worked before installing HA 2022.11.0

Browser and Operating System:
Chrome

Description of problem:
When the card is embedded in an entities card, there is a border around the flipdown timer card.
Before HA 2022.11.0, there was no border.

image

type: entities
entities:
  - entity: climate.air_climatise
    group: true
    type: custom:mini-climate
  - entity: timer.air_climatise
    type: custom:flipdown-timer-card

If we look at the same entities, but with native HA cards, there is still no border in 2022.11.0
image

type: entities
entities:
  - entity: climate.air_climatise
  - entity: timer.air_climatise

Also, the time picker card had the same issue, but they fixed it. Here is the link to it if it can help:
GeorgeSG/lovelace-time-picker-card#43

@julienlarivee julienlarivee added the bug Something isn't working label Dec 4, 2022
@BebeMischa
Copy link

That is a change in the design made by HA devs. See the HA forums. It's not a problem of this card. This HA change affects every card...

@pmongloid
Copy link
Owner

i think you should use vertical stack card.
let me know again if it doesn't solve the problem.

@julienlarivee
Copy link
Author

That is a change in the design made by HA devs. See the HA forums. It's not a problem of this card. This HA change affects every card...

I know they change the shadow for the border to be more inline with material design. The thing is before there was no shadow for the inner cards but now theses same cards have borders. This is not consequent. If we want to keep it consequent, there should be a border on the outter card, but not on the inner one.

@julienlarivee
Copy link
Author

i think you should use vertical stack card. let me know again if it doesn't solve the problem.

When using the vertical stack, we lose the the outter card that englobe the other two. Like this:
image

@pmongloid
Copy link
Owner

thanks for the test
the link is so helpful so i could fix it soon

@julienlarivee
Copy link
Author

@pmongloid Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants