Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to keep interpreter state around between invocation, and if so for how long #7

Open
pmonks opened this issue Jun 17, 2021 · 3 comments
Labels
help wanted Extra attention is needed task A task that may or may not result in changes to the code.

Comments

@pmonks
Copy link
Owner

pmonks commented Jun 17, 2021

The "if so how long" part is especially important, to prevent memory leaks. My initial thought is that this could be based on an inactivity period e.g. after X minutes of inactivity, the interpreter is reset.

@pmonks pmonks added the task A task that may or may not result in changes to the code. label Jun 17, 2021
@pmonks pmonks added the help wanted Extra attention is needed label Jun 17, 2021
@pmonks
Copy link
Owner Author

pmonks commented Jun 17, 2021

Very keen for others to weigh in on this!

@E-A-Griffin
Copy link

I'm not sure how long to keep it active for but maybe 5 minutes is a decent default. I also think some sort of means to persist source code or a session to be reloaded would be nice. Maybe via pinning a message or something else that would store the source code on the discord server using the bot.

@pmonks
Copy link
Owner Author

pmonks commented Jul 21, 2022

@E-A-Griffin regarding persisting interpreter state - the bigger question is whether this is useful enough to bother implementing (however it's done). Do you have a use case where the current approach doesn't work, and preserving interpreter state would be the best solution?

Regarding persisting the source code - this would probably be better discussed in a different issue, if you're open to creating one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed task A task that may or may not result in changes to the code.
Projects
None yet
Development

No branches or pull requests

2 participants