Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic Forms] Implement Comments functionality #1796

Open
1 of 3 tasks
Ruslan-Urban opened this issue Mar 21, 2024 · 2 comments
Open
1 of 3 tasks

[Dynamic Forms] Implement Comments functionality #1796

Ruslan-Urban opened this issue Mar 21, 2024 · 2 comments
Labels
help wanted Needs: Design 🎨 type:enhancement New feature or enhancement of existing capability

Comments

@Ruslan-Urban
Copy link

Category

  • Enhancement
  • Bug
  • Question

Version 3.17.0

Expected / Desired Behavior / Question

Standard SharePoint list forms implement Comments functionality. This functionality is required for our implementation for collaboration on tasks and issues.
Ideally, I would like to inject simple customizations into standard SharePoint forms, similar to injecting JSLink in classic forms. However, no such functionality exists in modern forms. For example, I need to set default value of the Org Unit field from a URL parameter value and make the field read only. Now, the only way we can implement it is with SPFx or Power Apps. Both options are an overkill and a deployment and maintenance nightmare. If there was a site collection feature to enable custom JavaScript injections, that would address a myriad of challenges.

Observed Behavior

Comments functionality is missing from Dynamic Forms component.

Steps to Reproduce

Implement Form Customizer extensions with a Dynamic Form for a list. Notice that Comments panel and show/hide button is missing from the form. Also, Comments option on the list item opens the Dynamic Form with missing comments controls.

@6gal6ler6
Copy link
Contributor

Did you try using this Reusable Component: https://pnp.github.io/sp-dev-fx-controls-react/controls/ListItemComments/ along with the Dynamic Form?

@michaelmaillot
Copy link
Collaborator

Hi @Ruslan-Urban,

You're right: the DynamicForm doesn't include the comments feature, it would be nice to have an option to display them.

Now regarding the display, as this control can be displayed anywhere (webpart, extension), maybe a first implementation would be to add them below the form buttons, don't you think?

@6gal6ler6 thtat's a nice suggestion, however the ListItemComments requests Graph permissions, which couldn't fit to every scenario (because of API consent in SP Admin). IMHO it would be better to rely on SP REST API only (and why not adding later a prop to enable Graph API usage).

@michaelmaillot michaelmaillot added help wanted Needs: Design 🎨 type:enhancement New feature or enhancement of existing capability labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Needs: Design 🎨 type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

3 participants