[Audit] Finish off the SMT audit

[Olshansk]

Objective

Address SMT audit concerns and lock-in MainNet SMT sha.

Origin Document

• 240404_Thesis Defense - Pocket Network Foundation - SMT - Security Audit Report (Final).pdf
• Thesis Defense-Pocket Network Foundation-SMT-Security Audit Report.pdf
• smt

Goals

• Address all audit concerns from the Thesis Defense team
• Finalize and lock in a hash that can get Shannon through to MainNet

Deliverables

• Review the audit reports provided in detail
• Review and merge in the PR from @h5law ([Audit] Address Audit Issues and Suggestions smt#42)
• Publicize the learnings and details

Non-goals / Non-deliverables

• Prepare future work such as:
  • Optimizing proof sizes
  • Refactoring the code for readability & maintainbility

General deliverables

• Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
• Testing: Add new tests (unit and/or E2E) to the test suite.
• Makefile: Add new targets to the Makefile to make the new functionality easier to use.
• Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

---

Creator: @Olshansk

[Olshansk]

First followup of questions: Reviewing Audit Report 80a867507a6e4ae0bfdea3667df00f1b.pdf

[Olshansk]

@bryanchriswhite @red-0ne @okdas For the curious ☝️

[Olshansk]

The thesis defense team will follow up in about 3-4 weeks. Given that the scope of work here was to reply to the feedback and merge in the updates, I'm marking this as done.

[Olshansk]

Response to the questions above. PoktSMTreportquestions.pdf

I will have a couple follow-ups that I'll link to here once done.