Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split off DataFrame serde functionality from read_json/DataFrame.write_json #14526

Closed
stinodego opened this issue Feb 16, 2024 · 0 comments · Fixed by #16550
Closed

Split off DataFrame serde functionality from read_json/DataFrame.write_json #14526

stinodego opened this issue Feb 16, 2024 · 0 comments · Fixed by #16550
Assignees
@stinodego
Labels
A-api Area: changes to the public API A-serde Area: seralization and deserialization accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Milestone
1.0.0

Comments

@stinodego
Copy link
Member

These two functions currently do double duty: they read/write generic JSON data, but they can also read/write a serialized DataFrame, including bit settings and data types.

I propose we add a DataFrame.serialize that does what DataFrame.write_json(pretty=False, row_oriented=False) currently does. DataFrame.write_json will remain and behave like row_oriented=True.

Similarly, a new classmethod DataFrame.deserialize is added for reading serialized DataFrames, and read_json will only read generic row oriented JSON data.

Thoughts?
@stinodego stinodego added python Related to Python Polars enhancement New feature or an improvement of an existing feature A-serde Area: seralization and deserialization A-api Area: changes to the public API labels Feb 16, 2024
@stinodego stinodego added this to the 1.0.0 milestone May 25, 2024
@stinodego stinodego self-assigned this May 25, 2024
@stinodego stinodego added the accepted Ready for implementation label May 26, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog May 26, 2024
@stinodego stinodego moved this from Ready to Next in Backlog May 26, 2024
@stinodego stinodego added needs decision Awaiting decision by a maintainer accepted Ready for implementation and removed accepted Ready for implementation needs decision Awaiting decision by a maintainer labels May 26, 2024
@stinodego stinodego moved this from Next to In progress in Backlog May 28, 2024
This was referenced May 28, 2024
Merged
Merged
@stinodego stinodego moved this from In progress to Blocked in Backlog May 28, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Backlog Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinodego stinodego

Labels
A-api Area: changes to the public API A-serde Area: seralization and deserialization accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Backlog
Archived in project
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

feat(python)!: Remove serde functionality from pl.read_json and DataFrame.write_json pola-rs/polars
1 participant
@stinodego