Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_file_paths parameter to read_parquet #18962

Closed
nameexhaustion opened this issue Sep 27, 2024 · 2 comments · Fixed by #19008
Closed

Add include_file_paths parameter to read_parquet #18962

nameexhaustion opened this issue Sep 27, 2024 · 2 comments · Fixed by #19008
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature good first issue Good for newcomers python Related to Python Polars

Comments

@nameexhaustion
Copy link
Collaborator

Description

Add the parameter and docstring and it when calling scan_parquet

@nameexhaustion nameexhaustion added good first issue Good for newcomers python Related to Python Polars enhancement New feature or an improvement of an existing feature accepted Ready for implementation labels Sep 27, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog Sep 27, 2024
@LukasFolwarczny
Copy link
Contributor

Hello! When the use_pyarrow parameter in read_parquet is set to True, the function _read_parquet_with_pyarrow is called instead of scan_parquet. However, the pyarrow function does not support the include_file_paths parameter. Would it be acceptable to add include_file_paths as incompatible with use_pyarrow and document this behavior accordingly?

@nameexhaustion
Copy link
Collaborator Author

Would it be acceptable to add include_file_paths as incompatible with use_pyarrow and document this behavior accordingly?

You can raise an error under the if use_pyarrow:section in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature good first issue Good for newcomers python Related to Python Polars
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants