Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr.head(0) silently returns 0 rows if other exprs have length of 1 #19108

Closed
2 tasks done
cmdlineluser opened this issue Oct 5, 2024 · 1 comment · Fixed by #19113
Closed
2 tasks done

expr.head(0) silently returns 0 rows if other exprs have length of 1 #19108

cmdlineluser opened this issue Oct 5, 2024 · 1 comment · Fixed by #19113
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars

Comments

@cmdlineluser
Copy link
Contributor

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl

df = pl.DataFrame({"foo": [1, 2], "bar": [3, 4]})

df.select(pl.col.foo.head(0), pl.col.bar.head(1))
# shape: (0, 2)
# ┌─────┬─────┐
# │ foo ┆ bar │
# │ --- ┆ --- │
# │ i64 ┆ i64 │
# ╞═════╪═════╡
# └─────┴─────┘

Log output

No response

Issue description

If another height is > 1 - it errors as expected:

df.select(pl.col.foo.head(0), pl.col.bar.head(2))
# ComputeError: Series length 0 doesn't match the DataFrame height of 2

Expected behavior

ComputeError

Installed versions

--------Version info---------
Polars:               1.9.0
Index type:           UInt32
Platform:             macOS-13.6.1-arm64-arm-64bit
Python:               3.12.2 (main, Feb  6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          <not installed>
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               <not installed>
gevent:               <not installed>
great_tables:         <not installed>
hvplot:               <not installed>
matplotlib:           <not installed>
nest_asyncio:         <not installed>
numpy:                1.26.4
openpyxl:             <not installed>
pandas:               2.2.1
pyarrow:              15.0.2
pydantic:             <not installed>
pyiceberg:            <not installed>
sqlalchemy:           <not installed>
torch:                <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>
@cmdlineluser cmdlineluser added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels Oct 5, 2024
@edwinvehmaanpera
Copy link
Contributor

edwinvehmaanpera commented Oct 5, 2024

Culprit seems to be this:

Ok(match series.len() {
0 if df_height == 1 => series,
1 => {
if has_empty {
polars_ensure!(df_height == 1,
ComputeError: "Series length {} doesn't match the DataFrame height of {}",
series.len(), df_height
);
series.slice(0, 0)

since df_height=max(series.len()) so with head(0)/ head(1) then df_height==1. I don't know what is special about df_height==1. This behaviour seems to have been introduced in #15903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants