Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect streaming scan_parquet().with_row_index() when scanning more than 1 file #19606

Closed
2 tasks done
nameexhaustion opened this issue Nov 3, 2024 · 0 comments · Fixed by #19609
Closed
2 tasks done
Assignees
Labels
A-io-parquet Area: reading/writing Parquet files A-streaming Related to the streaming engine accepted Ready for implementation bug Something isn't working P-high Priority: high python Related to Python Polars

Comments

@nameexhaustion
Copy link
Collaborator

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

print(
    pl.scan_parquet(2 * ["hf://datasets/nameexhaustion/polars-docs/iris.parquet"])
    .with_row_index()
    .collect(streaming=True)["index"]
    .to_list()
)

[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27,
28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53,
54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79,
80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104,
105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125,
126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146,
147, 148, 149, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24,
25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50,
51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76,
77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102,
103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123,
124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144,
145, 146, 147, 148, 149]

Log output

No response

Issue description

Row index begins at 0 for every file

Expected behavior

Row index offset begins at last file position for every file

Installed versions

1.12.0

@nameexhaustion nameexhaustion added bug Something isn't working python Related to Python Polars regression Issue introduced by a new release P-high Priority: high A-streaming Related to the streaming engine A-io-parquet Area: reading/writing Parquet files labels Nov 3, 2024
@nameexhaustion nameexhaustion self-assigned this Nov 3, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog Nov 3, 2024
@nameexhaustion nameexhaustion added rust Related to Rust Polars and removed regression Issue introduced by a new release rust Related to Rust Polars labels Nov 3, 2024
@nameexhaustion nameexhaustion changed the title Incorrect streaming scan_parquet().with_row_index() Incorrect streaming scan_parquet().with_row_index() when scanning more than 1 file Nov 3, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in Backlog Nov 4, 2024
@c-peters c-peters added the accepted Ready for implementation label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io-parquet Area: reading/writing Parquet files A-streaming Related to the streaming engine accepted Ready for implementation bug Something isn't working P-high Priority: high python Related to Python Polars
Projects
Archived in project
2 participants