-
Notifications
You must be signed in to change notification settings - Fork 32
Work after switching to attrs #45
Comments
Note: The example in Edit: For |
@noc0lour I'd say that |
No, somehow I expected in poliastro to be able to stick results from the CZML_extractor directly into a CZMLWidget, which is a poliastro issue not a czml3 issue. |
Oh, I see! Yep, |
Closing as not relevant as of #154 |
(Copied from #44)
This already passes all the tests locally.
Things that will have to be reworked:
Things I removed and I'd like to bring back:
Things I'd like to review:
default=None
everywhere)isinstance
(we are inconsistently using positive and negative checks)__attrs_post_init__
but we could use@x.validator
instead http://www.attrs.org/en/stable/init.html#decorator)KNOWN_PROPERTIES
(can I iterate overattrs
properties now instead?)StripeOrientationValue
)Things I'd like to add in the future:
The text was updated successfully, but these errors were encountered: