Support for ethereum-compatible types

[jacogr]

API version of polkadot-js/common#656

This needs unpacking, but some things I can immediately think of -

• AccountId needs to use 20-bytes, not 32
• AccountId needs to encode to the Ethereum version (display)
• Address needs to use the above
• Extrinsic, probably need hashing support as per this Support for Ethereum compatible ECDSA  common#656 (comment) (However this really is config dependent, i.e. is all hashes replaced, or just this singular, i.e. for large payloads)
• ...

There will be more, needs to be unpack actually looking at what Rust does

[jacogr]

cc @crystalin Anyhing else you can think of off the top of your head? Atm we have -

• [u8; 20] AccountIds (with Ethereum formatting)
• Support for Address type of the above
• Support for signing/hashing in extrinsics, i.e. keys should be correct in the tx (assuming non publicKey)
• The hasher can be completely swapped out to keccak (not sure this is in-use, I know Substrate had some issues initially with full replacement, but anyway, on chains that wish to replace blake2 with something else everywhere, can be done now)

Bit frustrating this since normally I tests e2e against dev nodes to ensure it works as expected.

[crystalin]

It looks good. I can test it tomorrow to see if there is anything missing.
My substrate implementation of the ethereum is at the moment very much a hack over current substrate ECDSA, I'll have to test it too.

For the signature of the payload, do you use the Ethereum signature (including the r,v,s) ?

[jacogr]

It does work with the current ecdsa implementation, have tested live txs with that on Kusama, so yes, exactly as output here - https://github.com/polkadot-js/common/blob/master/packages/util-crypto/src/secp256k1/sign.ts

(For Ethereum, I'm assuming is is "edcsa", so the first byte of the MultiSignature is 2 (just the normal enum position for the impl)

[crystalin]

Than you Jaco, great work !
I confirm it is working with a Ethereum compatible Substrate implementation.

As discussed, some further improvement (outside of this scope) could be to better support MultiSignature enums (or even single Signatures).

[jacogr]

Closing. (Splitting out signature replacement for Extrinsics in #2536)

[polkadot-js-bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.