-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a example-reactnative (port of existing) #218
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 2 weeks, 6 days from now. 1) cameronfr has been approved to start work. I'm willing to take a crack at this. FYI, to get the React example to build I had to set I'll be able to follow the best practices as well as provide good documentation so that people who land at the repo can easily get a working and non hack-y react-native app. Learn more on the Gitcoin Issue Details page. |
@cameronfr There is def. an issue that snuck in lately, the ui-keyring got some additional functionality that plays a bit of havoc here it would seem. The browser fields in the package.json doesn't quite seem to yield the desired results inside this workspaced repo.(Externally it seems to behave fine) Will get that sorted. |
@cameronfr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Sorry for the delay. I've got a relatively clean configuration going without rn-nodeify etc. that can generate the mnemonic etc. Currently working on somehow replacing the synchronous "store" package with something asynchronous (react-native only has asynchronous storage). I'll probably use something that syncs an in-memory storage to react-native's AsyncStorage. |
np thanks for the update here @cameronfr |
@cameronfr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@gitcoinbot We are close :) PR is there, last dangling bits. #223 @cameronfr You probably just need to link it on Gitcoin. |
Thank you! @Web3Foundation Can you please schedule payment on this bounty? |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 300.0 DAI (300.0 USD @ $1.0/DAI) has been submitted by: @Web3Foundation please take a look at the submitted work:
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @cameronfr.
|
Thanks for completing this bounty @cameronfr do you mind taking this 2 minute survey about your experience with this issue! https://forms.gle/QgWdQoTykMKH2Q3B8 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query. |
Background:
This repos is a set of UI libraries that can be used across frameworks. For some frameworks (React, React Native & Vue), we do have specific components available, but there are some specific framework-specific things to take care of.
Recently we have introduced a very simple key generator example for both React as well as Vue. Functionality wise (and even UI wise), these are equivalent.
There are some "tricks" to getting React Native to operate properly, especially with the WASM libs (RN has an asm.js fallback), which has yielded example repos such as https://github.com/jacogr/rn-wasm-crypto in the past
Goals:
We would like a port of the above example for React Native. For inclusion here we would like a clean example that is runnable via
yarn run example:rn:ios
&yarn run example:rn:android
This means it should be able to -
Additionally it needs to -
@polkadot/ui-settings
@polkadot/ui-keyring
Functionality-wise (excluding the icons where not all themes are available), it should be equivalent to the existing examples. Additionally, we really want to set a "best practice" example, i.e. we really don't want to do this - https://github.com/jacogr/rn-wasm-crypto/blob/master/package.json#L18 that means setup should be done such that "hacks" are not needed, rather fallbacks to proper RN equivalents where applicable.
Lastly, if any issues do pop up in using the
@polkadot/*
dependencies, log issues, indicate here and it will be addressed. (Part of the reason for doing this is making sure the road is clear for others)Additional reading:
The text was updated successfully, but these errors were encountered: