Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing settings in Query-to-File #307

Open
vogti opened this issue Mar 31, 2021 · 8 comments · May be fixed by polypheny/Query-to-File#3
Open

Allow editing settings in Query-to-File #307

vogti opened this issue Mar 31, 2021 · 8 comments · May be fixed by polypheny/Query-to-File#3
Assignees
@PrakruthiSomashekar
Labels
A-qtf Area: Query-to-File C-enhancement Category: An issue proposing an enhancement E-good-first-issue P-high Priority: High

Comments

@vogti
Copy link
Member

vogti commented Mar 31, 2021

This issue requires some experience with JavaFX.

The Query-to-File interface has a config.properties file where certain settings need to be specified. It would be great to integrate these settings into the JavaFX based user interface. Some settings (like the path to fuse binary or the Polypheny-DB host address) should be configurable on startup.
@vogti vogti added C-enhancement Category: An issue proposing an enhancement P-high Priority: High E-good-first-issue A-qtf Area: Query-to-File labels Mar 31, 2021
@PrakruthiSomashekar
Copy link

Hi @vogti, I'm trying to understand the requirement. Please correct me if I'm wrong.

  1. When Main program is run, JavaFX based user interface has to come up with TextFields to enter settings (host address, port, etc.)
  2. Once the fields are entered and submitted, the application will start using the given settings.
  3. Should default values be configured incase some of the fields are left blank while submitting?

@vogti
Copy link
Member Author

vogti commented May 23, 2021

Hi @PrakruthiSomashekar, welcome to Polypheny! Would you like to take care of this issue?

  1. Exactly
  2. Exactly
  3. It makes sense to have default values. I would suggest pre-filling all input fields with these default values. It might be beneficial to keep a settings file and take the default values from that file.

It would be great if you can take care of this issue.

@PrakruthiSomashekar
Copy link

PrakruthiSomashekar commented May 24, 2021 •
edited
Loading

Thanks @vogti! happy to contribute:)
Can you please suggest parameters from this list for input?

  1. reconnectionTimeout
  2. host
  3. port
  4. fuseCapacityGB
  5. libraryPath

fyi, I've picked these from config.properties file

@vogti
Copy link
Member Author

vogti commented May 24, 2021

Perfect :) I have assigned the issue to you.
I think 2, 3 and 5 should definitely be configurable on startup. Regarding 5: The idea is that this should be determined automatically in future (trying different typical locations depending on the operating system). Nevertheless, it is always possible that the system has a very special configuration which requires manually specifying the location of the fuse binary.

@PrakruthiSomashekar
Copy link

@vogti, please review the PR mentioned below. Thanks.
polypheny/Query-to-File#3

@vogti vogti linked a pull request May 30, 2021 that will close this issue
Open
@vogti
Copy link
Member Author

vogti commented May 30, 2021

@PrakruthiSomashekar Thank you for the PR. You may want to join our Discord server via the following link: https://discord.gg/xuBXEy4g

@Shyamsaibethina
Copy link

Hi, This issue has not been worked in a while, could I be assigned to it if it hasn't been solved yet?

@PrakruthiSomashekar
Copy link

PrakruthiSomashekar commented Mar 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrakruthiSomashekar PrakruthiSomashekar

Labels
A-qtf Area: Query-to-File C-enhancement Category: An issue proposing an enhancement E-good-first-issue P-high Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow editing settings PrakruthiSomashekar/Query-to-File
3 participants
@vogti @Shyamsaibethina @PrakruthiSomashekar