-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need ProcessMonitor windows support #1203
Comments
Any PR will be gratefully accepted. |
Ideally, I think this should be delayed until #1014 is completed. Then, we can make sure that they are feature equivalent. However, #1014 has been open for a long time so I don't think that is actually reasonable. Rather, whoever implements ProcessMonitor support for Windows needs to be aware of the issue that is still outstanding in the *nixen version. |
I started working on this somewhat.. at the very least I can contribute a thin c wrapper for windows processes. Then maybe start incorporating it into proc monitor. |
@Triangle345 Thanks! |
How should we test this functionality. Should I add a windows section to the test file? I notice it is currently linux specific. |
Yes. If tests that are currently Linux and OSX only pass then we can feel confident that Windows support is working. |
@Triangle345 once that is in place, if you are interested in further extending ProcessMonitor support then you could revive this PR to bring async write buffering support (which would then be across platforms). Its old and somewhat dated but could serve as a good basis for additional work. |
@cquinn I think this can be closed, do you agree? |
Yes, I think so. ProcessMonitor on Windows could be improved, but it works OK. |
Currently the process monitor is only written/works for linux.
For windows one would need to use the createprocess call:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx
The text was updated successfully, but these errors were encountered: