ponyc fails to compile on FreeBSD 12.2

[mneumann]

FreeBSD 12.2 uses clang 10.0.1 as base compiler. Compilation fails during building gbenchmark:

In file included from /tmp/cirrus-ci-build/build/build_libs/gbenchmark-prefix/src/gbenchmark/test/cxx03_test.cc:5:
In file included from /tmp/cirrus-ci-build/build/build_libs/gbenchmark-prefix/src/gbenchmark/include/benchmark/benchmark.h:172:
In file included from /usr/include/c++/v1/algorithm:643:
/usr/include/c++/v1/memory:4190:60: error: too many arguments provided to function-like macro invocation
static_assert( is_constructible<_Tp, _Args...>::value, "Can't construct object in allocate_shared" );
^
/usr/include/sys/cdefs.h:292:9: note: macro '_Static_assert' defined here
#define _Static_assert(x, y) __Static_assert(x, __COUNTER__)
^
In file included from /tmp/cirrus-ci-build/build/build_libs/gbenchmark-prefix/src/gbenchmark/test/cxx03_test.cc:5:
In file included from /tmp/cirrus-ci-build/build/build_libs/gbenchmark-prefix/src/gbenchmark/include/benchmark/benchmark.h:172:
In file included from /usr/include/c++/v1/algorithm:643:
/usr/include/c++/v1/memory:4190:105: error: expected '('
static_assert( is_constructible<_Tp, _Args...>::value, "Can't construct object in allocate_shared" );
^
/usr/include/c++/v1/memory:4395:59: error: too many arguments provided to function-like macro invocation
static_assert(is_constructible<_Tp, _Args...>::value, "Can't construct object in make_shared");
^
/usr/include/sys/cdefs.h:292:9: note: macro '_Static_assert' defined here
#define _Static_assert(x, y) __Static_assert(x, __COUNTER__)
^
In file included from /tmp/cirrus-ci-build/build/build_libs/gbenchmark-prefix/src/gbenchmark/test/cxx03_test.cc:5:
In file included from /tmp/cirrus-ci-build/build/build_libs/gbenchmark-prefix/src/gbenchmark/include/benchmark/benchmark.h:172:
In file included from /usr/include/c++/v1/algorithm:643:
/usr/include/c++/v1/memory:4395:99: error: expected '('
static_assert(is_constructible<_Tp, _Args...>::value, "Can't construct object in make_shared");
^

[SeanTAllen]

I wonder if this is "as simple as" updating to a later version of google benchmark.

I don't know much about it, @kulibali, I feel like you might. Thoughts?

[SeanTAllen]

Upgrading to google benchmark 1.5.2 fixes the issue. There's a PR already open that will be merged soon.

#3706

[SeanTAllen]

Thanks for finding and reporting this @mneumann.

[SeanTAllen]

Closing this as the PR will be merged soon.