From 7a1c66feea217481aa8ec3f0e2934408b68e6dcf Mon Sep 17 00:00:00 2001 From: Michael Aaron Murphy Date: Thu, 1 Aug 2019 17:08:07 -0600 Subject: [PATCH] fix(gtk): Improve the layout of revealer changelogs Fixes for #18 --- gtk/src/changelog.rs | 14 ++++++++------ gtk/src/state.rs | 6 +++--- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/gtk/src/changelog.rs b/gtk/src/changelog.rs index c7ca363..8d116bf 100644 --- a/gtk/src/changelog.rs +++ b/gtk/src/changelog.rs @@ -11,6 +11,7 @@ where ..show_all(); }; + let mut initiated = false; changelog.for_each(|(version, entry)| { let markdown = if entry.as_ref().is_empty() { Cow::Borrowed("No changelog available") @@ -42,12 +43,13 @@ where .margin_end(margin) .build(); - changelog_entries.add(&cascade! { - gtk::Box::new(gtk::Orientation::Vertical, 12); - ..add(&version); - ..add(>k::Separator::new(gtk::Orientation::Horizontal)); - ..add(&changelog); - }); + if initiated { + changelog_entries.add(>k::Separator::new(gtk::Orientation::Horizontal)); + } + + initiated = true; + changelog_entries.add(&version); + changelog_entries.add(&changelog); }); changelog_entries diff --git a/gtk/src/state.rs b/gtk/src/state.rs index 3167adc..97f5b54 100644 --- a/gtk/src/state.rs +++ b/gtk/src/state.rs @@ -65,9 +65,8 @@ impl State { view_devices: DevicesView, view_empty: EmptyView, ) -> Self { - let has_battery = upower_dbus::UPower::new(-1) - .and_then(|upower| upower.on_battery()) - .unwrap_or(false); + let has_battery = + upower_dbus::UPower::new(-1).and_then(|upower| upower.on_battery()).unwrap_or(false); Self { entities: Entities::default(), @@ -294,6 +293,7 @@ fn reveal gtk::Container>( gtk::Box::new(gtk::Orientation::Vertical, 12); ..set_vexpand(true); ..add(>k::Separator::new(gtk::Orientation::Horizontal)); + ..add(>k::LabelBuilder::new().label("Changelog").use_markup(true).xalign(0.0).build()); ..add(&widget); ..show_all(); };