Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System became lagging randomly after trivial code change #2345

Closed
zxkmm opened this issue Nov 7, 2024 · 0 comments
Closed

System became lagging randomly after trivial code change #2345

zxkmm opened this issue Nov 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zxkmm
Copy link
Contributor

zxkmm commented Nov 7, 2024

Originally found by @htotoo

A. what happened

The system (or only UI, or UI caused system) got lagging appeared after trivial random code edit.
for example:

  1. add one more item in an array, it became lagging, but deleted that item fixed.
  2. add an return in a function that should return there, became lagging, and use a bool to bypass following code instead of using return, weirdly fixed.

B. how can tell if current firmware has this issue

  1. in the navigation page, the tile appears one by one like having animations
  2. in the home page, the time text field flashing when ticking seconds
  3. in microphone and recon apps (because these two have many widgets so more obvious), the widgets appears one by one slowly.

C. what we currently found

1.

Seems not related to whether external apps and standalone apps exist or not

2.

make clean or ninja clean, then build won't make differences, but for test, better clean before building

D. related talk:

https://discord.com/channels/719669764804444213/1301516615212470343

E. discover log

1.

firstly found after #2302 were merged, AKA 8d1fb7c , fixed by workaround in #2307

2.

appeared again in the halfway of work in #2331 but fixed in same PR by use bool instead of return

3.

appeared again in the halfway of work in #2333 but also fixed in same PR by use bool instead of return

@zxkmm zxkmm pinned this issue Nov 7, 2024
@zxkmm zxkmm added bug Something isn't working help wanted Extra attention is needed labels Nov 7, 2024
@zxkmm zxkmm changed the title System (UI) lagging issue appear after random code change System (UI) lagging issue appear after random trivial code change Nov 7, 2024
@zxkmm zxkmm changed the title System (UI) lagging issue appear after random trivial code change System (UI) lagging issue appear randomly after trivial code change Nov 7, 2024
@zxkmm zxkmm changed the title System (UI) lagging issue appear randomly after trivial code change System (or only UI) lagging issue appear randomly after trivial code change Nov 7, 2024
@zxkmm zxkmm changed the title System (or only UI) lagging issue appear randomly after trivial code change System became lagging randomly after trivial code change Nov 7, 2024
@zxkmm zxkmm changed the title System became lagging randomly after trivial code change Remove Fake Brightness Nov 8, 2024
@zxkmm zxkmm removed the help wanted Extra attention is needed label Nov 8, 2024
@zxkmm zxkmm changed the title Remove Fake Brightness System became lagging randomly after trivial code change Nov 8, 2024
@zxkmm zxkmm closed this as completed Nov 8, 2024
@zxkmm zxkmm unpinned this issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant