New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update signature for tab_spanners to indicate label can be md(), html() result #348

Closed

machow opened this issue May 15, 2024 · 0 comments · Fixed by #434

Collaborator

machow commented May 15, 2024

#345 supported having more than a single spanner. As a part of that, we added some quick logic for labels that are md() and html() result objects.

Let's be sure to...

update the tab_spanners label annotation to reflect these objects are possible
update the logic to use isinstance checks rather then hasattr.

(Alternatively we could use structural subtyping and support anything with a specific attribute, but I'd lock it down for now!)

rich-iannone mentioned this issue

fix: use isinstance() instead of hasattr() #434

Merged

rich-iannone closed this as completed in #434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment