Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ark: Jupyter: Verbose logging makes jupyter-console unusable #2098

Closed
Tracked by #2264
lionel- opened this issue Jan 22, 2024 · 1 comment
Closed
Tracked by #2264

Ark: Jupyter: Verbose logging makes jupyter-console unusable #2098

lionel- opened this issue Jan 22, 2024 · 1 comment
Assignees
Labels
area: kernels Issues related to Jupyter kernels and LSP servers lang: r

Comments

@lionel-
Copy link
Contributor

lionel- commented Jan 22, 2024

By default (i.e. --log option not supplied) we stream log messages to stdout/stderr. This makes jupyter-console unusable when verbosity is high because jupyter-client, used by jupyter-console, launches the kernel with subprocess.Popen() without stdout capture, which causes the kernel streams to be inherited by the jupyter-console REPL process.

To fix this we could add a --log-temp option that would create log files in $TEMPDIR/ark-logs. These would be time-stamped to make it easy to find the relevant log file when debugging. Supplying both --log and --log-temp would be an error. We would supply that option by default in our kernel.json file.

@DavisVaughan
Copy link
Contributor

Looks like things are pretty quiet now on Mac and Windows, I even checked the reprex from #4382 too

Screenshot 2024-09-30 at 4 02 18 PM Screenshot 2024-09-30 at 4 10 22 PM Screenshot 2024-09-30 at 4 12 03 PM

Probably worth looking into this at some point

D:\Users\davis-vaughan\AppData\Local\Programs\Python\Python312\Lib\site-packages\jupyter_console\ptshell.py:136: UserWarning: No lexer found for language ''. Treating as plain text.
  warn("No lexer found for language %r. Treating as plain text." % name)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: kernels Issues related to Jupyter kernels and LSP servers lang: r
Projects
None yet
Development

No branches or pull requests

4 participants